[Pkg-samba-maint] Anyone feeling like digging into the patches and see whether we still need them?

[Christian Perrier]

Following a talk, here, focused on projects that the Samba Team has to
autobuild their software for many platforms and OS "vendors", I was
thinking about our patches.

An ideal situation would of course be having no patches at all so that
both us and them could use the same build system..:-)

So, let's look:

bubulle at mykerinos:~/src/debian/samba/samba-3.0.25rc2/debian/patches> ls -l
total 696
-rw-rw-r-- 1 bubulle bubulle    736 2007-04-24 11:07 adapt_machine_creation_script.patch
-rw-rw-r-- 1 bubulle bubulle 583517 2007-04-24 08:28 autoconf.patch
-rw-rw-r-- 1 bubulle bubulle    544 2007-04-24 11:07 cups.patch
-rw-rw-r-- 1 bubulle bubulle  13289 2007-04-24 11:07 documentation.patch
-rw-rw-r-- 1 bubulle bubulle  23065 2007-04-24 11:07 fhs.patch
-rw-rw-r-- 1 bubulle bubulle    743 2007-04-24 11:07 installswat.sh.patch
-rw-rw-r-- 1 bubulle bubulle    644 2007-04-24 11:07 make-distclean.patch
-rw-rw-r-- 1 bubulle bubulle    771 2007-04-24 11:07 nmbd-signalling.patch
-rw-rw-r-- 1 bubulle bubulle   2037 2007-04-24 11:07 non-linux-ports.patch
-rw-rw-r-- 1 bubulle bubulle    566 2007-04-24 11:07 pam-examples.patch
-rw-rw-r-- 1 bubulle bubulle    922 2007-04-24 08:28 python-examples.patch
-rw-rw-r-- 1 bubulle bubulle    523 2007-04-24 11:07 README_nosmbldap-tools.patch
-rw-rw-r-- 1 bubulle bubulle   2654 2007-04-24 11:07 samba.patch
-rw-rw-r-- 1 bubulle bubulle    417 2007-04-24 11:08 series
-rw-rw-r-- 1 bubulle bubulle    569 2007-04-24 11:07 smbclient-pager.patch
-rw-rw-r-- 1 bubulle bubulle   1240 2007-04-24 08:28 smbclient-tar.patch.unused
-rw-rw-r-- 1 bubulle bubulle    626 2007-04-24 11:07 smbmount-mtab-flags.patch
-rw-rw-r-- 1 bubulle bubulle   4441 2007-04-24 11:07 smbmount-nomtab.patch
-rw-rw-r-- 1 bubulle bubulle    701 2007-04-24 11:07 smbmount-unix-caps.patch
-rw-rw-r-- 1 bubulle bubulle    730 2007-04-24 11:07 smbstatus-locking.patch
-rw-rw-r-- 1 bubulle bubulle    649 2007-04-24 11:07 undefined-symbols.patch
-rw-rw-r-- 1 bubulle bubulle    534 2007-04-24 11:07 VERSION.patch

We don't have *that* a huge set of patches. Does anyone in the team
(even if I'm currently too loud in this team) feel like digging into
these patches and see whether it's really good to keep them?

For instance, I find it quite strange that we still have the
cups.patch patch. Shouldn't we default to CUPS also, now?

Also inserting comments like the ones we use in the shadow package
maintenance would be good:

Goal: allow non numerical group identifier to be specified with useradd's
      and usermod's -g options

Fixes: #381394, #381399, #381404, #381408, #381448

Status wrt upstream: Applied in CVS

Index: shadow-4.0.18.1/src/useradd.c
===================================================================
--- shadow-4.0.18.1.orig/src/useradd.c	2006-09-17 12:25:16.499523435 +0200
+++ shadow-4.0.18.1/src/useradd.c	2006-09-17 12:25:28.379617865 +0200

.../...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20070425/8c4a5c10/attachment.pgp