[Pkg-samba-maint] r1604 - branches/samba/no-more-smbfs/debian/patches

vorlon at alioth.debian.org vorlon at alioth.debian.org
Sat Nov 24 10:11:10 UTC 2007


Author: vorlon
Date: 2007-11-24 10:11:10 +0000 (Sat, 24 Nov 2007)
New Revision: 1604

Removed:
   branches/samba/no-more-smbfs/debian/patches/hide_password_length.patch
Log:
drop hide_password_length.patch, another smbmount-specific patch



Deleted: branches/samba/no-more-smbfs/debian/patches/hide_password_length.patch
===================================================================
--- branches/samba/no-more-smbfs/debian/patches/hide_password_length.patch	2007-11-24 10:09:27 UTC (rev 1603)
+++ branches/samba/no-more-smbfs/debian/patches/hide_password_length.patch	2007-11-24 10:11:10 UTC (rev 1604)
@@ -1,42 +0,0 @@
-Goal: Seems to be meant to avoid one to guess the password's length
-      by how many Xs are left in the argv buffer
-
-Fixes: some paranoid coniderations?
-
-Status wrt upstream: Forwarded on 2007/05/30
-
-Author: Unknown
-
-Note: 
-
-Index: samba-3.0.25a/source/client/smbmount.c
-===================================================================
---- samba-3.0.25a.orig/source/client/smbmount.c	2007-05-26 07:45:39.744216228 +0200
-+++ samba-3.0.25a/source/client/smbmount.c	2007-05-26 07:46:32.692638041 +0200
-@@ -768,7 +768,7 @@
- 					*lp = 0;
- 					pstrcpy(password,lp+1);
- 					got_pass = True;
--					memset(strchr_m(opteq+1,'%')+1,'X',strlen(password));
-+					memset(strchr_m(opteq+1,'%')+1,'\0',strlen(password));
- 				}
- 				if ((lp=strchr_m(username,'/'))) {
- 					*lp = 0;
-@@ -778,7 +778,7 @@
- 				  !strcmp(opts, "password")) {
- 				pstrcpy(password,opteq+1);
- 				got_pass = True;
--				memset(opteq+1,'X',strlen(password));
-+				memset(opteq+1,'\0',strlen(password));
- 			} else if(!strcmp(opts, "credentials")) {
- 				pstrcpy(credentials,opteq+1);
- 			} else if(!strcmp(opts, "netbiosname")) {
-@@ -892,7 +892,7 @@
- 			*p = 0;
- 			pstrcpy(password,p+1);
- 			got_pass = True;
--			memset(strchr_m(getenv("USER"),'%')+1,'X',strlen(password));
-+			memset(strchr_m(getenv("USER"),'%')+1,'\0',strlen(password));
- 		}
- 		strupper_m(username);
- 	}




More information about the Pkg-samba-maint mailing list