[Pkg-samba-maint] Dropping smbstatus-locking.patch?

[Steve Langasek]

On Sun, Oct 07, 2007 at 10:06:15AM +0200, Christian Perrier wrote:
> I briefly mentioned this in #samba-technical but better discuss it
> here...

> This patch was meant to fix #164179: weird message when running
> smbstatus on a server where no client connected.

> That bug was caused by an inexisting locking.tdb file in
> /var/run/samba.

> Since then, it appears that the smbd daemon, when launched normally,
> creates that file if it doesn't exist.

> So, #164179 is only likely to show up on a system where locing.tdb is
> voluntarily removed by the local admin, which is a weird idea.

No, locking.tdb is in /var/run, so this bug happens under any circumstances
where smbstatus is run after a reboot where smbd has not been started,
either due to runlevel policy or due to a configuration failure.

> Therefore, I propose dropping that patch which would anyway need to be
> modified for 3.2.0 as Volker Lendecke pointed in the samba-technical
> mailing list.

> Comments?

> I checked this with 3.2.0. I didn't check what happens with an
> unpatched 3.0.26a...and don't really plan to do so. So, I rpopose
> dropping the patch in 3.2.0

If smbstatus still exits non-zero when locking.tdb is absent, it's still a
bug.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon at debian.org                                   http://www.debian.org/