[Pkg-samba-maint] Bug#394770: Logfiles rotation: do we really need it?

[Steve Langasek]

On Tue, Apr 15, 2008 at 10:57:22AM +0200, Christian Perrier wrote:
> Just bringed in a discussion around here at SambXP.

> We still have a weekly logrotate entry for log.smbd and log.nmbd.

> However, Samba does its own log rotation internally. Moreover, as this
> bug shows, as we only reload samba, the *old* files are still used.

> In short, log rotation probably doesn't make sense. So, indeed, should
> we keep it?

> On the other hand, samba's rotation scheme is much more crude than
> logrotate's (only rename the old logfile to .old)....but, at this
> time, this seems to be the only usable one.

I don't see that samba's built-in rotation is usable at all.  It's
completely inconsistent with the logrotate system that's used for all other
logs; it doesn't support keeping more than one old logfile around, and
there's no support for rotation by date, only by file size.  I don't think
that's adequate; if there are problems with Samba not reopening logfiles
when we need it to, I think that's a bug to be fixed.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org