[Pkg-samba-maint] Bug#299618: Possible patch for this issue

[Steve Langasek]

On Sun, Dec 07, 2008 at 11:47:01AM +0100, Christian Perrier wrote:
> tags 299618 patch
> thanks

> Back in 2005(!), Marc reported that samba's DHCP hook script does not
> remove existing WINS servers from /etc/samba/dhcp.conf when the DHCP
> server does not provide any WINS server address.

> The attached patch should fix this.

> Please comment. If it is OK, I'll activate it in the experimentl
> branch.

> Index: samba-common.dhcp
> ===================================================================
> --- samba-common.dhcp	(révision 2219)
> +++ samba-common.dhcp	(copie de travail)
> @@ -23,7 +23,8 @@
>  	then
>  		# don't continue if no settings have changed
>  		if [ "$new_netbios_name_servers" = "$old_netbios_name_servers" ] \
> -		   && [ "$new_netbios_scope" = "$old_netbios_scope" ]
> +		   && [ "$new_netbios_scope" = "$old_netbios_scope" ] \
> +		   && [ -n "$new_netbios_name_servers" ]
>  		then
>  			return
>  		fi

Isn't the right fix to not exclude RELEASE and STOP as recognized reasons,
instead?  That would seem to be the way to ensure the update is done when
the interface is brought down, not just the next time the interface is
brought up.

Actually, both changes are probably needed here, to handle different cases
in which the wins server value needs to be cleared.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org