[Pkg-samba-maint] Asking for review of ctdb package before asking for a sponsor
Peter Eisentraut
peter_e at gmx.net
Wed Jan 30 15:16:17 UTC 2008
Am Mittwoch, 30. Januar 2008 schrieb Mathieu PARENT:
> My ctdb package is almost finished. I need some help to validate
> against debian policy. This is my first package, so i may miss
> some essential step.
Some comments:
* README.Debian: It is content-free and redundant; remove it.
* changelog: Remove spaces before colons.
* changelog: I would separate the date from the version number by some other
means, such as 1.0.24+git200801221422-1.
* control: It should be XS-Vcs-Svn and XS-Vcs-Browser.
* control: Put a slash at the end of XS-Vcs-Svn.
* control: There is a long list of Suggests, but it is not clear in what
contexts those packages would be useful.
* control: The description could use a few more sentences.
* control: If it depends on ethtool, it must be Priority extra.
* control: I don't think this package actually depends on logrotate. That
would be unusual.
* docs: You don't need to install README.build, as it is not useful for users
of the package.
* postinst, postrm, preinst, prerm: Remove these, since they don't do
anything.
* rules: Clean up this file. Remove all the comments "Add here ...", all the
example commands that are commented out, all the targets you don't need. The
get-orig-source-bzr target is unclear to me, as ctdb uses git.
> My get-orig-source target-git (in debian/rules) should call build-orig.sh
> from the debian directory. How to do this ?
Call sh debian/build-orig.sh I guess.
> Should I use soname or something similar ?
I don't see a library in your package.
More information about the Pkg-samba-maint
mailing list