[Pkg-samba-maint] Bug#488275: Bug#488275: samba and winbind: initscript miss 'status' option

[Steve Langasek]

On Thu, Jul 03, 2008 at 05:39:31PM +0200, Tim Stoop wrote:

> Op 2-jul-2008, om 5:54 heeft Steve Langasek het volgende geschreven:
>>>> I think it would be better to first fix winbind to use a proper PID
>>>> file,
>>>> then use code similar to that in the smbd/nmbd case.

>>> I'll spend some time today to see if I can fix that. I guess the --
>>> make-pidfile option from start-stop-daemon should be used. Will let 
>>> you
>>> know when I come up with something that works.

>> Ok, thanks for the interest!

> I'm a bit confused about the following part of the winbind init script:

>     mkdir -p /var/run/samba/winbindd_privileged || return 1
>     chgrp winbindd_priv $PIDDIR/winbindd_privileged/ || return 1
>     chmod 0750 $PIDDIR/winbindd_privileged/ || return 1

> I'm guessing it's only used to check if there's already a winbind  
> running? Or is the directory used for anything else? Can I remove this 
> and replace it with the usage of --make-pidfile in start-stop-daemon?

This is to ensure that the /var/run/samba heirarchy is created before use,
in the event that the system uses a tmpfs for /var/run (and therefore
directories don't persist across reboots).

No, this has nothing at all to do with pidfiles - the existing code is
correct and should not be altered.  Nor should the
/var/run/samba/winbindd_privileged directory be used for pidfiles.

(I don't know why we have $PIDDIR used in some cases and not others - that's
an inconsistency that we should correct at some point.)

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org