[Pkg-samba-maint] r1956 - in trunk/samba/debian: . patches

[ctrlsoft-guest at alioth.debian.org]

tags 486056 pending
thanks

Author: ctrlsoft-guest
Date: 2008-06-15 14:43:49 +0000 (Sun, 15 Jun 2008)
New Revision: 1956

Added:
   trunk/samba/debian/patches/smbtar-bashism.patch
Modified:
   trunk/samba/debian/changelog
   trunk/samba/debian/patches/series
Log:
Fix bashism in smbtar.

Modified: trunk/samba/debian/changelog
===================================================================
--- trunk/samba/debian/changelog	2008-06-15 11:15:50 UTC (rev 1955)
+++ trunk/samba/debian/changelog	2008-06-15 14:43:49 UTC (rev 1956)
@@ -1,6 +1,10 @@
 samba (2:3.0.30-4) UNRELEASED; urgency=low
 
+  [ Christian Perrier ]
   * Rename libcupsys2-dev to libcups2-dev in build dependencies
+  
+  [ Jelmer Vernooij ]
+  * Fix bashism in smbtar. (Closes: #486056)
 
  -- Christian Perrier <bubulle at debian.org>  Fri, 13 Jun 2008 08:16:47 +0200
 

Modified: trunk/samba/debian/patches/series
===================================================================
--- trunk/samba/debian/patches/series	2008-06-15 11:15:50 UTC (rev 1955)
+++ trunk/samba/debian/patches/series	2008-06-15 14:43:49 UTC (rev 1956)
@@ -16,3 +16,4 @@
 usershare.patch
 disable-weak-auth.patch
 no-unnecessary-cups.patch
+smbtar-bashism.patch

Added: trunk/samba/debian/patches/smbtar-bashism.patch
===================================================================
--- trunk/samba/debian/patches/smbtar-bashism.patch	                        (rev 0)
+++ trunk/samba/debian/patches/smbtar-bashism.patch	2008-06-15 14:43:49 UTC (rev 1956)
@@ -0,0 +1,23 @@
+Goal: Avoid using bashism in smbtar
+
+Status wrt upstream: Debian-specific. 
+
+Fixes: #486056
+
+Author: Jelmer Vernooij <jelmer at samba.org>
+
+Note:
+
+Index: samba/source/script/smbtar
+===================================================================
+--- samba/source/script/smbtar	(Revision 1955)
++++ samba/source/script/smbtar	(Arbeitskopie)
+@@ -151,7 +151,7 @@
+ if [ -z "$verbose" ]; then
+       echo "server    is $server"
+ #     echo "share     is $service"
+-      echo "share     is $service\\$cdcmd"
++      printf "share     is %s\\%s" "$service" "$cdcmd"
+       echo "tar args  is $tarargs"
+ #     echo "password  is $password"  # passwords should never be sent to screen
+       echo "tape      is $tapefile"