[Pkg-samba-maint] Bug#433449: Another ubuntu patch: reload samba when interfaces are bringed up

[Steve Langasek]

On Sat, Mar 15, 2008 at 12:13:35PM +0100, Christian Perrier wrote:
> A recent Ubuntu patch, discussed in
> https://bugs.launchpad.net/ubuntu/+source/samba/+bug/180493
> seems quite OK to me, but still for 3.0.28a-2:

>   * debian/samba.if-up
>      - ifup hook to reload samba once the interfaces comes up. (LP: #180493)

> This involves adding debian/samba.if-up and the following to
> debian/rules at the end of the install: target:

>        mkdir -p $(DESTDIR)/etc/network/if-up.d
>         install -o root -g root debian/samba.if-up $(DESTDIR)/etc/network/if-up.d/samba

> I changed the Ubuntu script to use invoke-rc.d instead of direct calls
> to /etc/init.d/samba

> Advices? Comments?

Oh.  This patch does not achieve its stated purpose, for two reasons:

- the file is missing from debian/samba.files, so never gets installed to
  the package.
- the /etc/init.d/samba reload target only reloads smbd, it does nothing
  to nmbd - certainly nothing that would start nmbd in the case that it was
  not running!

I'm reopening LP bug #180493.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org