[Pkg-samba-maint] Bug#483187: Bug#483187: samba: recommended action (smb.conf.master) is broken

[Richard A Nelson]

On Wed, 28 May 2008, Christian Perrier wrote:

> Quoting Richard A Nelson (cowboy at debian.org):
>>
>> In the new version of smb.conf is this section:
>>
>> # A well-established practice is to name the original file
>> # "smb.conf.master" and create the "real" config file with
>> # testparm -s smb.conf.master >smb.conf
>> # This minimizes the size of the really used smb.conf file
>> # which, according to the Samba Team, impacts performance
>
> Actually, one of upstream's recommendations is to *not* use this
> method when include files that use macros are used..:-)
>
> Exactly for the reason you described..

Interesting, in that it was the include that didn't use macros
that was kept in the generated file...  The macro based include
was the one that was silently removed (seems to me, the situation
should be reversed).

> We should probably add this to the comment.

My plan was to use this on each machine when smb.conf.master was
updated (via cfengine2) - and so the limited use of macros is, in
my case, a non-issue... the generated file would be correct for 
each machine.

The fact that the non-macro based include was kept is the issue -
as that file has all the details for the realm...  Granted, sed
could easily rememdy that problem, but it seems rather hackish;
at that point I think I'll just leave the structure/comments as
they are.
-- 
Rick Nelson
"What you end up with, after running an operating system concept through
these many marketing coffee filters, is something not unlike plain hot
water."
(By Matt Welsh)