[Pkg-samba-maint] Bug#541367: winbind: Missing init.d $syslog script dependency

[Petter Reinholdtsen]

Package:  winbind
Version:  3.0.23c-2
Severity: important
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d scripts. The dependencies are not completely
correct.  The daemons log to syslog, and should start after the syslog
collector is started.  Also, the dependency on $local_fs is redundant
($remote_fs depend on $local_fs), and can be dropped.

<URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Without it, the init.d start to
early in the boot sequence, and some syslog messages might get lost.

diff -ur samba-3.4.0/debian/winbind.init samba-3.4.0-pere/debian/winbind.init
--- samba-3.4.0/debian/winbind.init     2009-08-13 19:24:23.000000000 +0200
+++ samba-3.4.0-pere/debian/winbind.init        2009-08-13 19:25:02.000000000 +0200
@@ -2,8 +2,8 @@

 ### BEGIN INIT INFO
 # Provides:          winbind
-# Required-Start:    $network $local_fs $remote_fs
-# Required-Stop:     $network $local_fs $remote_fs
+# Required-Start:    $network $remote_fs $syslog
+# Required-Stop:     $network $remote_fs $syslog
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: start Winbind daemon

Happy hacking,
-- 
Petter Reinholdtsen