[Pkg-samba-maint] DO NOT REPLY [Bug 6651] smbd SIGSEGV when breaking oplocks

samba-bugs at samba.org samba-bugs at samba.org
Fri Aug 21 22:17:45 UTC 2009


jra at samba.org changed:

           What    |Removed                     |Added
               Flag|                            |review?(metze at samba.org)

------- Comment #10 from jra at samba.org  2009-08-21 17:17 CST -------
Pushed to master. Please review.

Another problem with your patch Petr was that your modification to
tevent_common_signal_handler_info() used SIG_QUEUE_IDX (defiend as #define
SIG_QUEUE_IDX(sig) (sig_state->signal_count[(sig)].count %
SA_INFO_QUEUE_COUNT) to index the position to store the incoming signal
siginfo_t. However, you need to use the .seen element as the base of the index
for storage (+count). Your index should have been SIG_DEQUEUE_IDX(sig, count)
(using your definition of SIG_DEQUEUE_IDX) to store in incoming siginfo_t.

I preferred to make these calculations explicit in the patch I pushed.

git formatted patch for 3.4.1 to follow.


Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You reported the bug, or are watching the reporter.

More information about the Pkg-samba-maint mailing list