[Pkg-samba-maint] Bug#514019: option syslog does not work

[Claudius Peschke]

Package: samba
Version: 2:3.2.5-4cpe1
Severity: normal
Tags: patch


The option "syslog" in smb.conf does not work. I have the lines

[global]
 syslog = 2
 syslog only = Yes

in my smb.conf, but smbd and nmbd does not send messages to syslog. 
The problem is an wrong error handling. This is already fixed in 
Samba 3.2.6. With the following patch, the output to syslog works 
correctly.

--- samba-3.2.5.orig/source/lib/debug.c	2008-11-18 16:17:17.000000000 +0100
+++ samba-3.2.5/source/lib/debug.c	2009-02-03 10:10:22.000000000 +0100
@@ -849,7 +849,7 @@
 		ret = vasprintf(&msgbuf, format_str, ap);
 		va_end(ap);
 
-		if (ret == -1) {
+		if (ret != -1) {
 			syslog(priority, "%s", msgbuf);
 		}
 		SAFE_FREE(msgbuf);

-- System Information:
Debian Release: 5.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages samba depends on:
ii  adduser              3.110               add and remove users and groups
ii  debconf [debconf-2.0 1.5.24              Debian configuration management sy
ii  libacl1              2.2.47-2            Access control list shared library
ii  libattr1             1:2.4.43-1          Extended attribute shared library
ii  libc6                2.7-18              GNU C Library: Shared libraries
ii  libcomerr2           1.41.3-1            common error description library
ii  libcups2             1.3.8-1lenny4.1     Common UNIX Printing System(tm) - 
ii  libgnutls26          2.4.2-4             the GNU TLS library - runtime libr
ii  libkrb53             1.6.dfsg.4~beta1-5  MIT Kerberos runtime libraries
ii  libldap-2.4-2        2.4.11-1            OpenLDAP libraries
ii  libpam-modules       1.0.1-5             Pluggable Authentication Modules f
ii  libpam-runtime       1.0.1-5             Runtime support for the PAM librar
ii  libpam0g             1.0.1-5             Pluggable Authentication Modules l
ii  libpopt0             1.14-4              lib for parsing cmdline parameters
ii  libtalloc1           1.2.0~git20080616-1 hierarchical pool based memory all
ii  libwbclient0         2:3.2.5-4cpe1       client library for interfacing wit
ii  logrotate            3.7.1-5             Log rotation utility
ii  lsb-base             3.2-20              Linux Standard Base 3.2 init scrip
ii  procps               1:3.2.7-11          /proc file system utilities
ii  samba-common         2:3.2.5-4cpe1       Samba common files used by both th
ii  update-inetd         4.31                inetd configuration file updater
ii  zlib1g               1:1.2.3.3.dfsg-12   compression library - runtime

samba recommends no packages.

Versions of packages samba suggests:
pn  ldb-tools                   <none>       (no description available)
ii  openbsd-inetd [inet-superse 0.20080125-2 The OpenBSD Internet Superserver
pn  smbldap-tools               <none>       (no description available)

-- debconf information:
  samba/run_mode: daemons
  samba/generate_smbpasswd: true