[Pkg-samba-maint] Bug#521408: samba: W2k3 replies with NT_STATUS_INVALID_SID, even if other SIDs in the list are valid.

[Pavel]

Package: samba
Version: 2:3.2.5-4
Severity: normal
Tags: patch


Please consider following patch for debian stable:

diff --git a/source/passdb/lookup_sid.c b/source/passdb/lookup_sid.c
index a7175b9..d767fa4 100644
--- a/source/passdb/lookup_sid.c
+++ b/source/passdb/lookup_sid.c
@@ -804,7 +804,7 @@ NTSTATUS lookup_sids(TALLOC_CTX *mem_ctx, int num_sids,
 		} else {
 			/* This is a normal SID with rid component */
 			if (!sid_split_rid(&sid, &rid)) {
-				result = NT_STATUS_INVALID_PARAMETER;
+				result = NT_STATUS_INVALID_SID;
 				goto fail;
 			}
 		}
diff --git a/source/rpc_server/srv_lsa_nt.c b/source/rpc_server/srv_lsa_nt.c
index 9ce992c..9d411ec 100644
--- a/source/rpc_server/srv_lsa_nt.c
+++ b/source/rpc_server/srv_lsa_nt.c
@@ -830,6 +830,10 @@ NTSTATUS _lsa_LookupSids(pipes_struct *p,
 					   &names,
 					   &mapped_count);
 
+	if (NT_STATUS_IS_ERR(status)) {
+		return status;
+	}
+
 	/* Convert from lsa_TranslatedName2 to lsa_TranslatedName */
 	names_out = TALLOC_ARRAY(p->mem_ctx, struct lsa_TranslatedName,
 				 num_sids);

More info:
https://bugzilla.samba.org/attachment.cgi?id=4009&action=view
https://bugzilla.samba.org/show_bug.cgi?id=6097

Can be applied also for testing (anyway, will be included in samba release).


Thank you,
Pavel


-- System Information:
Debian Release: 5.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=cs_CZ.UTF-8, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages samba depends on:
ii  adduser              3.110               add and remove users and groups
ii  debconf [debconf-2.0 1.5.24              Debian configuration management sy
ii  libacl1              2.2.47-2            Access control list shared library
ii  libattr1             1:2.4.43-2          Extended attribute shared library
ii  libc6                2.7-18              GNU C Library: Shared libraries
ii  libcomerr2           1.41.3-1            common error description library
ii  libcups2             1.3.8-1lenny4.1     Common UNIX Printing System(tm) - 
ii  libgnutls26          2.4.2-6+lenny1      the GNU TLS library - runtime libr
ii  libkrb53             1.6.dfsg.4~beta1-5  MIT Kerberos runtime libraries
ii  libldap-2.4-2        2.4.11-1            OpenLDAP libraries
ii  libpam-modules       1.0.1-5             Pluggable Authentication Modules f
ii  libpam-runtime       1.0.1-5             Runtime support for the PAM librar
ii  libpam0g             1.0.1-5             Pluggable Authentication Modules l
ii  libpopt0             1.14-4              lib for parsing cmdline parameters
ii  libtalloc1           1.2.0~git20080616-1 hierarchical pool based memory all
ii  libwbclient0         2:3.2.5-4           client library for interfacing wit
ii  logrotate            3.7.1-5             Log rotation utility
ii  lsb-base             3.2-20              Linux Standard Base 3.2 init scrip
ii  procps               1:3.2.7-11          /proc file system utilities
ii  samba-common         2:3.2.5-4           Samba common files used by both th
ii  update-inetd         4.31                inetd configuration file updater
ii  zlib1g               1:1.2.3.3.dfsg-12   compression library - runtime

samba recommends no packages.

Versions of packages samba suggests:
pn  ldb-tools                     <none>     (no description available)
pn  openbsd-inetd | inet-superser <none>     (no description available)
pn  smbldap-tools                 <none>     (no description available)

-- debconf information excluded