[Pkg-samba-maint] [obnox at samba.org: about the non-linux ports patch from bug #266693]

[Michael Adam]

Hi Robert - and thanks for your reply.

Robert Millan wrote:
> On Wed, May 06, 2009 at 12:14:25PM +0200, Michael Adam wrote:
> >
> > Robert - can you read this? :-)
> 
> Hi!
> 
> Wow, it's been a while.  Let's see if I can help...
> 
> > > The patch has several hunks like this:
> > > 
> > > -    *linux*)
> > > +    linux*-gnu* | gnu* | k*bsd*-gnu)
> > > 
> > > This has the potential disadvantage that it may make
> > > less systems match. I'd change this to the following:
> > > 
> > > -    *linux*)
> > > +    *linux* | gnu* | k*bsd*-gnu)
> > > 
> > > Or are there good reasons for being more restrictive?
> 
> I don't remember any reason for that.

OK, so in order to reduce side effects, I will use
the second form.

> Note, however, that there's now kopensolaris*-gnu, could you
> match that one as well for everything that involves glibc or
> gnuish userland?

Sure that will be no problem.

> > > Another hunk that I found strange in the current version is this:
> > > 
> > > -    *freebsd[[5-9]]*)
> > > +    freebsd5*|*freebsd[[6-9]]*)
> > > 
> > > This seems to have evolved from the original hunk:
> > > 
> > > -    *freebsd5*)
> > > +    freebsd5*)
> > > 
> > > I suspect that this is meant to _not_ match the
> > > k*bsd*-gnu patterns from the above hunks, right?
> 
> Yes.

OK, but then the correct extrapolated new patch would be
freebsd[[5-9]]* instead of freebsd5*|*freebsd[[6-9]]* ... :-)

But still in that case statement, the freebsd*-gnu stuff is aready
caught above, and I would still leave that hunk at
*freebsd[[5-9]]*) so not to make other *freebsd* candidates fail.

This might be paranoid, but I don't like surpises of that kind...

> > > BTW: If anyone could put a Debian GNU/kFreeBSD or other GNU/*bsd*
> > > machine into the samba build farm (http://build.samba.org/),
> > > that would really help monitoring the working of such changes!
> > > Note that donation just means using some harddisk space and cpu
> > > cycles.
> 
> I suggest you ask debian-bsd at lists.debian.org.

Ok, thanks for the hint!

Cheers - Michael

-- 
Michael Adam <ma at sernet.de>  <obnox at samba.org>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20090506/6d824d01/attachment-0001.pgp>