[Pkg-samba-maint] [obnox at samba.org: about the non-linux ports patch from bug #266693]

[Michael Adam]

Robert Millan wrote:
> On Wed, May 06, 2009 at 08:14:52PM +0200, Michael Adam wrote:
> > > > > The patch has several hunks like this:
> > > > > 
> > > > > -    *linux*)
> > > > > +    linux*-gnu* | gnu* | k*bsd*-gnu)
> > > > > 
> > > > > This has the potential disadvantage that it may make
> > > > > less systems match. I'd change this to the following:
> > > > > 
> > > > > -    *linux*)
> > > > > +    *linux* | gnu* | k*bsd*-gnu)
> > > > > 
> > > > > Or are there good reasons for being more restrictive?
> > > 
> > > I don't remember any reason for that.
> > 
> > OK, so in order to reduce side effects, I will use
> > the second form.
> 
> I think I remember.  It was done under the assumption that you would
> want to exclude things like "linux-aout", "linux-uclibc", etc from
> Glibc-specific checks.

Ok, this seems to makes sense, but I'll keep it separate,
so as not to change several aspects in one patch. Also, I
will have to review all occurrences whether linux-<notgnu>
should be excluded in all cases.

Cheers - Michael

-- 
Michael Adam <ma at sernet.de>  <obnox at samba.org>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20090508/5bfc7875/attachment.pgp>