[Pkg-samba-maint] Backporting talloc 2.0.1 to lenny-backports

[Jelmer Vernooij]

On Mon, 2010-02-08 at 06:46 +0100, Christian PERRIER wrote:
> Quoting Jelmer Vernooij (jelmer at samba.org):
> > > Any objections?
> > > (the backport is quite straightforward)
> > None here. Go for it :-)
> Thanks. One question, though:
> 
> I checked yesterday that indeed samba 3.4.3  could be compiled with
> talloc 1.2.0 (the version in lenny) while 3.4.5 fails at the configure
> step (saying that talloc isn't here).

> From my limited abilities to understand autostuff, it seems that the
> test checks for talloc version to be above 1.3.0:
> 
> source3/configure.in:
> if test "x$enable_external_libtalloc" != xno
> then
> 	PKG_CHECK_MODULES(TALLOC, talloc >= 1.3.0, 
> 		[ enable_external_libtalloc=yes ],
> 		[ if test "x$enable_external_libtalloc" = xyes; then
> 		 	AC_MSG_ERROR([Unable to find libtalloc])
> 	      else 
> 			enable_external_libtalloc=no
> 		  fi
> 		])
> fi
> 
> So, it seems fair that the test fails when talloc is 1.2.0. But why
> the hell, doesn't it fail when I compile samba 3.4.3 while it fails
> when compiling 3.4.5?

> This apparently requires us to raise the build dependency we currently
> have on libtalloc-dev, even in unstable, which is why I ask around.
That's odd indeed - perhaps we didn't mandate the use of a system talloc
in the Samba Debian package in 3.4.3 while we do in 3.4.5? That's the
only possible explanation I can think of at the moment.

According to git blame I introduced the requirement for talloc 1.3.0 in
March of last year, and as far as I can tell that change made it into
3.4.3 already.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20100208/708b3104/attachment.pgp>