[Pkg-samba-maint] /etc/logrotate.d/winbind misleading logrotate to report failure

[Steve Langasek]

> <lkml at think-future.de>: host mailin01.mx.bawue.net[193.7.176.63] said: 550
>     <lkml at think-future.de>: Recipient address rejected: User unknown in virtual
>     alias table (in reply to RCPT TO command)

<shrug>

On Sun, Feb 14, 2010 at 01:08:56PM -0800, Steve Langasek wrote:
> On Sun, Feb 14, 2010 at 02:09:21PM +0100, lkml at think-future.de wrote:
> >   Hi,
> 
> > winbind 2:3.4.5~dfsg-1
> 
> > ISSUE:
> > /etc/logrotate.d/winbind contains a postrotate script:
> > [ -f /var/run/samba/winbindd.pid ] && kill -HUP `cat /var/run/samba/winbindd.pid` 2>/dev/null
> 
> > When winbind hasn't been running, there's no /var/run/samba/winbindd.pid and maybe even not a
> > /var/run/samba/ directory. The -f test fails and returns 1 which in turn makes logrotate 
> > report a failure.
> 
> > FIX:
> > As i.e. apache2 does, wrapping the test in an if-clause fixes this issue:
> >   postrotate
> >     if [ -f /var/run/samba/winbindd.pid ]; then
> >        kill -HUP `cat /var/run/samba/winbindd.pid` 2>/dev/null;
> >     fi;
> >   endscript
> 
> Please file a bug report on submit at bugs.debian.org, so this doesn't get lost.
> 
> -- 
> Steve Langasek                   Give me a lever long enough and a Free OS
> Debian Developer                   to set it on, and I can move the world.
> Ubuntu Developer                                    http://www.debian.org/
> slangasek at ubuntu.com                                     vorlon at debian.org



> _______________________________________________
> Pkg-samba-maint mailing list
> Pkg-samba-maint at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-samba-maint


-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20100214/efca81e0/attachment-0001.pgp>