[Pkg-samba-maint] DO NOT REPLY [Bug 7021] Memory leaks with 3.2 series

samba-bugs at samba.org samba-bugs at samba.org
Mon Jan 18 13:31:22 UTC 2010


https://bugzilla.samba.org/show_bug.cgi?id=7021





------- Comment #16 from naoliv at gmail.com  2010-01-18 07:31 CST -------
(In reply to comment #15)
> Applied them as http://people.debian.org/~naoliv/misc/samba-7020.patch

Another "hmmmmmmmm" here:

rpc_server/srv_pipe_hnd.c: In function 'read_from_internal_pipe':
rpc_server/srv_pipe_hnd.c:1089: error: 'output_data' has no member named 'frag'
rpc_server/srv_pipe_hnd.c:1094: error: 'output_data' has no member named 'frag'

What would be the correct code for this (if possible and if applicable
), please?

diff -ur samba-3.2.5/source/rpc_server/srv_pipe_hnd.c
samba-3.2.5/source/rpc_server/srv_pipe_hnd.c
--- samba-3.2.5/source/rpc_server/srv_pipe_hnd.c        2008-11-18
15:17:17.000000000 +0000
+++ samba-3.2.5/source/rpc_server/srv_pipe_hnd.c        2010-01-18
13:12:13.000000000 +0000
@@ -1086,6 +1086,13 @@
   out:

        (*is_data_outstanding) = p->out_data.current_pdu_len > n;
+       if (p->out_data.current_pdu_sent == prs_offset(&p->out_data.frag)) {
+               /* We've returned everything in the out_data.frag
+                * so we're done with this pdu. Free it and reset
+                * current_pdu_sent. */
+               p->out_data.current_pdu_sent = 0;
+               prs_mem_free(&p->out_data.frag);
+       }
        return data_returned;
 }


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.



More information about the Pkg-samba-maint mailing list