[Pkg-samba-maint] Advice on #221618 (libsmbclient-dev: 64bits prototype not precised)

[Steve Langasek]

On Wed, Jun 08, 2011 at 06:39:06AM +0200, Christian PERRIER wrote:
> Quoting Steve Langasek (vorlon at debian.org):
> > On Tue, Jun 07, 2011 at 07:32:17PM +0200, Christian PERRIER wrote:
> > > Do you guys ahave an advice about this bug report?

> > Should be fixed by setting '#define _LARGEFILE64_SOURCE' and '#define
> > _FILE_OFFSET_BITS 64' in the header.

> <mode bubulle_is_very_dumb>

> You mean just dropping these two lines at top of libsmbclient.h?

Yep.

> Should this be done upstream?

It should be discussed upstream, but it's potentially an ABI change upstream
for those platforms which were *not* previously building with LFS support so
more caution is required there.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20110608/82d028b2/attachment.pgp>