[Pkg-samba-maint] Bug#221618: Bug#221618: Advice on #221618 (libsmbclient-dev: 64bits prototype not precised)

[Andrew Bartlett]

On Thu, 2011-06-09 at 06:42 +0200, Christian PERRIER wrote:
> tags 221618 patch
> thanks
> 
> Quoting Steve Langasek (vorlon at debian.org):
> > On Wed, Jun 08, 2011 at 06:39:06AM +0200, Christian PERRIER wrote:
> > > Quoting Steve Langasek (vorlon at debian.org):
> > > > On Tue, Jun 07, 2011 at 07:32:17PM +0200, Christian PERRIER wrote:
> > > > > Do you guys ahave an advice about this bug report?
> > 
> > > > Should be fixed by setting '#define _LARGEFILE64_SOURCE' and '#define
> > > > _FILE_OFFSET_BITS 64' in the header.
> > 
> > > <mode bubulle_is_very_dumb>
> > 
> > > You mean just dropping these two lines at top of libsmbclient.h?
> > 
> > Yep.
> > 
> > > Should this be done upstream?
> > 
> > It should be discussed upstream, but it's potentially an ABI change upstream
> > for those platforms which were *not* previously building with LFS support so
> > more caution is required there.
> 
> 
> So, the attached patch shold be the fix. Let's record that.

This seems a pretty dangerous define to put into a public header,
included in other software...

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org