[Pkg-samba-maint] r3705 - in trunk/samba: . debian

[Steve Langasek]

On Sat, Mar 12, 2011 at 08:55:13PM +0100, Jelmer Vernooij wrote:

> On Sat, 2011-03-12 at 10:12 -0800, Steve Langasek wrote:
> > On Sat, Mar 12, 2011 at 05:11:07PM +0000, jelmer at alioth.debian.org wrote:
> > > debian/samba.if-up: Use invoke-rc.d.
> > Why is this change needed?  invoke-rc.d is only a policy requirement for
> > maintainer scripts, not for other integration scripts on the system; and,
> It was inspired by a lintian warning, script-calls-init-script-directly:

> "This script apparently runs an init script directly rather than using
> invoke-rc.d. While use of invoke-rc.d is only required for maintainer
> scripts, supporting the policy layer that it implements is a good idea
> in any script."

Ugh, that's a wrong thing for lintian to do.  I've filed bug #617959 on
lintian for this.

> > since we're checking status anyway, there's no risk here of accidentally
> > starting nmbd when we're not supposed to.  Whereas by calling 'invoke-rc.d
> > samba status', we're proxying through an additional policy layer which could
> > accidentally interfere with starting nmbd up when needed.  This is a case
> > where we *don't* want to respect the invoke-rc.d policy layer, we want a
> > simple rule here: "if smbd is running and nmbd isn't, try to start nmbd".

> > So I think this should be reverted.
> Thanks for the explanation, I've reverted it. Why would we not want to
> follow the invoke-rc.d policy in this case though?

Because admins can start services by hand out of runlevel, and if the admin
has done this, the if-up script should take correct action to start nmbd if
it's not already running.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20110312/4c28067e/attachment.pgp>