[Pkg-samba-maint] Bug#640668: samba: Updated if-up.d script to function under systemd

[Sam Morris]

On Mon, 2011-09-12 at 11:01 +0100, Steve Langasek wrote:
> Hi Sam,
> 
> On Tue, Sep 06, 2011 at 01:40:34PM +0100, Sam Morris wrote:
> > When systemd is installed, the behaviour of '/etc/init.d/samba status'
> > changes (systemd changes the LSB init functions to launch services via
> > systemctl rather than directly) in a way that breaks the if-up.d script.
> 
> > I've modified the script to get it to work again; see below.
> 
> Why should this not be fixed in systemd?  I don't think it's appropriate for
> the status_of_proc() function to give different output under systemd than
> under sysvinit and to require a package that isn't aware of systemd at all
> to cope with such divergence.

I don't really care whether it's systemd or samba that has to be updated
to fix the bug. I filed #640508 against systemd to make the maintainers
aware that their replacement of the LSB init script functions break
samba. :)

AIUI, the if-up.d script is really just a bandage that deals with the
case where nmbd exits because, when it's launched, there are no network
interfaces that are up. Without modifying the samba package so that it
ships one init script for smbd and one for nmbd, or so that it ships
systemd service files, modifying the if-up.d script so that it takes
account of the init script's differing behaviour under systemd seemed
like the path of least resistance.

-- 
Sam Morris <sam at robots.org.uk>