[Pkg-samba-maint] Bug#249873: Updated patch

[Steve Langasek]

On Sun, Apr 29, 2012 at 10:01:51AM -0400, Nikolaus Rath wrote:

> >This changes the privatedir path, but I don't see any handling here for
> >the existing files in /etc/samba that need to be moved on upgrade to
> >preserve functionality.  In addition to the obvious smbpasswd, there are
> >references to lp_private_dir() scattered throughout the source3
> >directory; these each need to be handled properly on package upgrade
> >(presumably by moving the files).

> Did you read the other comments on this bug? There is no need to move
> anything, since no samba directories are changed.

You are mistaken.  The current value of privatedir used in the package is
/etc/samba.  Anything in the source that currently references privatedir is
going to be created/looked for in /etc/samba, *not* in /var/lib/samba.  The
trivial proof of this is /etc/samba/smbpasswd which, while not used by
default in Debian, needs to be handled gracefully on upgrades.

So someone needs to actually audit the remaining references to the
privatedir in the code, and make sure they're handled correctly on upgrade.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20120429/d80cba18/attachment.pgp>