[Pkg-samba-maint] r4141 - trunk/samba/debian

[Ivo De Decker]

Steve,
Christian,

On Tue, Jun 26, 2012 at 02:27:17PM -0700, Steve Langasek wrote:
> > It seems libsmbclient exports private symbols. This started with version
> > 2:3.6.2-1.
> 
> Why did this start?  Is there a regression in our packaging, or an upstream
> regression?  Or is the problem simply that there are more private symbols
> than there were before?

I don't really know. The diff between 2:3.6.1-3 and 2:3.6.2-1 shows an
upstream change that might be related, so I suspect upstream, but I didn't
investigate further.

> How do we know which of the symbols are private?  No private symbols should
> be listed in a .symbols file, ever.  So if all of these are private symbols,
> we should fix that (with or without an upstream fix for the wrong
> exporting).

The upstream build system contains code to make sure only the public symbols
are exported. For some reason, the relevant options are not passed to gcc
anymore. I managed to fix this with a hardcoded hack and committed a patch for
this. This should be investigated further later (to find a proper fix), but I
don't know if we can do that before the freeze.

Does this all make sense to you?

With this latest patch, the version in svn builds fine and seems to work (I
only did very basic testing), so if it also works for you, I think it can be
uploaded.

Cheers,

Ivo