[Pkg-samba-maint] Bug#719477: winbind 2:4.0.8+dfsg-1 fails to upgrade: systemd service file does not start the daemon

[Matteo Settenvini]

Package: winbind
Version: 2:4.0.8+dfsg-1
Severity: serious
Justification: Policy 9.1.4

Dear Maintainer,

the systemd service file for winbind is not able to start the daemon
for samba versions > 4.x. 

`journalctl -xu winbind` reports:



ago 12 10:35:50 orchid systemd[1]: Starting Samba Winbind Daemon...
-- Subject: Unit winbind.service has begun with start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- 
-- Unit winbind.service has begun starting up.
ago 12 10:35:50 orchid systemd[1]: PID file /run/winbindd.pid not readable (yet?) after start.
ago 12 10:37:20 orchid systemd[1]: winbind.service operation timed out. Terminating.
ago 12 10:37:20 orchid systemd[1]: Failed to start Samba Winbind Daemon.
-- Subject: Unit winbind.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
-- Documentation: http://www.freedesktop.org/wiki/Software/systemd/catalog/be02cf6855d2428ba40df7e9d022f03d
-- 
-- Unit winbind.service has failed.
-- 
-- The result is failed.
ago 12 10:37:20 orchid systemd[1]: Unit winbind.service entered failed state.



This makes me think that the pidfile is not created by winbindd, while
the corresponding service file (/lib/systemd/system/winbind.service)
is waiting for it.

A possible solution is to alter the service file to force the pidfile
being created in the expected place (/run). Hence, changing the
ExecStart line to:


ExecStart=/usr/sbin/winbindd "$WINBINDOPTIONS" --option=piddirectory=/run


I put this at the end, so that we are sure it's always overriding
other options possibly set by the user (since the service file itself
requires the pid being created in /run).

This fixes the issue for me.

Thanks!
Matteo

-- System Information:
Debian Release: jessie/sid
  APT prefers experimental
  APT policy: (800, 'experimental'), (800, 'unstable'), (800, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.10-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.utf8, LC_CTYPE=it_IT.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages winbind depends on:
ii  libbsd0                0.6.0-1
ii  libc6                  2.17-92
ii  libcomerr2             1.42.8-1
ii  libdcerpc0             2:4.0.8+dfsg-1
ii  libgensec0             2:4.0.8+dfsg-1
ii  libkrb5-26-heimdal     1.6~git20120403+dfsg1-3
ii  libldap-2.4-2          2.4.31-1+nmu2
ii  libndr-standard0       2:4.0.8+dfsg-1
ii  libndr0                2:4.0.8+dfsg-1
ii  libpopt0               1.16-7
ii  libsamba-credentials0  2:4.0.8+dfsg-1
ii  libsamba-hostconfig0   2:4.0.8+dfsg-1
ii  libsamba-util0         2:4.0.8+dfsg-1
ii  libsmbclient-raw0      2:4.0.8+dfsg-1
ii  libtalloc2             2.0.8-1
ii  libtdb1                1.2.12-1
ii  libtevent0             0.9.19-1
ii  libwbclient0           2:4.0.8+dfsg-1
ii  samba                  2:4.0.8+dfsg-1
ii  samba-common-bin       2:4.0.8+dfsg-1

winbind recommends no packages.

Versions of packages winbind suggests:
iu  libnss-winbind  2:4.0.8+dfsg-1
iu  libpam-winbind  2:4.0.8+dfsg-1

-- no debconf information