[Pkg-samba-maint] [samba] 12/29: vfs_glusterfs: Fix excessive debug output from vfs_gluster_open().

[Jelmer Vernooij]

This is an automated email from the git hooks/post-receive script.

jelmer pushed a commit to branch samba_4.1
in repository samba.

commit 05c955383af76dddf45221933922e5c2dd6b5aaf
Author: Christopher R. Hertel <crh at redhat.com>
Date:   Thu Aug 29 16:58:16 2013 -0500

    vfs_glusterfs: Fix excessive debug output from vfs_gluster_open().
    
    The vfs_gluster_open() function generates a debug message (at level 0)
    for every failed attempt to open a pathname.  This includes cases in
    which attempts are made to open a directory as a file (those attempts
    are retried calling vfs_gluster_opendir()).  The result is that the log
    file fills with messages about failed attempts to open directories, just
    because they are directories.
    
    This latest version, of the patch completely removes logging from the
    vfs_gluster_open() function.  The error code returned is handled in
    upper layers, and the open function in the default VFS module does not
    log any errors.
    
    Signed-off-by: Christopher R. Hertel <crh at redhat.com>
    Reviewed-by: susant palai <spalai at redhat.com>
    Reviewed-by: raghavendra talur <rtalur at redhat.com>
    Reviewed-by: Jose A. Rivera <jarrpa at redhat.com>
    
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Aug 30 02:43:48 CEST 2013 on sn-devel-104
    
    The last 3 patches address bug #10224 - Patches to fix small problems in the
    vfs_glusterfs module.
---
 source3/modules/vfs_glusterfs.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c
index eac1b24..237236a 100644
--- a/source3/modules/vfs_glusterfs.c
+++ b/source3/modules/vfs_glusterfs.c
@@ -481,11 +481,8 @@ static int vfs_gluster_open(struct vfs_handle_struct *handle,
 	}
 
 	if (glfd == NULL) {
-		DEBUG(0, ("glfs_{open[dir],creat}(%s) failed: %s\n",
-			  smb_fname->base_name, strerror(errno)));
 		return -1;
 	}
-
 	return glfd_fd_store(glfd);
 }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-samba/samba.git