[Pkg-samba-maint] [PATCH] Drop smbtar-bashism.patch

[Steve Langasek]

On Sun, May 26, 2013 at 09:17:41PM +1000, Andrew Bartlett wrote:
> I'm trying not to have debian carry patches that have been rejected
> upstream.

> This patch was, and I think given it was just a mass bug filing, we
> should just drop it.  Should it be somehow noted on the bug?
> http://bugs.debian.org/486056

Well, it seems that the checkbashisms script was updated subsequent to that
bug report to drop the warning for \\, with the explanation:

 Author: Adam D. Barratt <adsb at debian.org>
 Date:   Sun May 31 17:17:42 2009 +0000

    Remove "\\" from the list of unsafe backslash escapes, as it appears to
    work in all shells.

So while this may still be a POSIX issue, it's not a practical issue for
Debian, so I'm ok with dropping this patch.  However, if this were still
causing misbehavior under dash, I would insist on keeping the patch despite
the upstream bug having been marked "invalid".  (And in that case I would
want to reopen the upstream bug.)

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20130526/1db8ca64/attachment.pgp>