[Pkg-samba-maint] Bug#726326: samba: status subcommand of samba init script fails with testparm problems

[Chris Boot]

Package: samba
Version: 2:3.6.19-1~bpo70+1
Severity: important

Dear Maintainer,

After installing the backported version of Samba on a wheezy machine,
'service samba status' returned a failure without printing the status of
either nmbd or smbd. Adding 'set -x' to the init script showed that
the testparm command used to retrieve the value of 'disable netbios'
returns exit code 1 on this system, which aborts processing the init
script at that point due to 'set -e' being given at the top of the
script.

Changing the line to add "|| true" to the command fixes the issue. This
makes the line read:

NMBD_DISABLED=`testparm -s --parameter-name='disable netbios'
2>/dev/null || true`

The fact that testparm complains about a slight mis-configuration should
not impact 'service samba status' from operating correctly.

Best regards,
Chris

-- System Information:
Debian Release: 7.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages samba depends on:
ii  adduser           3.113+nmu3
ii  dpkg              1.16.12
ii  libacl1           2.2.51-8
ii  libattr1          1:2.4.46-8
ii  libc6             2.13-38
ii  libcap2           1:2.22-1.2
ii  libcomerr2        1.42.5-1.1
ii  libcups2          1.5.3-5+deb7u1
ii  libgssapi-krb5-2  1.10.1+dfsg-5+deb7u1
ii  libk5crypto3      1.10.1+dfsg-5+deb7u1
ii  libkrb5-3         1.10.1+dfsg-5+deb7u1
ii  libldap-2.4-2     2.4.31-1+nmu2
ii  libpam-modules    1.1.3-7.1
ii  libpam-runtime    1.1.3-7.1
ii  libpam0g          1.1.3-7.1
ii  libpopt0          1.16-7
ii  libtalloc2        2.0.7+git20120207-1
ii  libtdb1           1.2.10-2
ii  libtevent0        0.9.16-1
ii  libwbclient0      2:3.6.19-1~bpo70+1
ii  lsb-base          4.1+Debian8+deb7u1
ii  procps            1:3.3.3-3
ii  samba-common      2:3.6.19-1~bpo70+1
ii  update-inetd      4.43
ii  zlib1g            1:1.2.7.dfsg-13

Versions of packages samba recommends:
ii  logrotate  3.8.1-4
ii  tdb-tools  1.2.10-2

Versions of packages samba suggests:
pn  ctdb                              <none>
pn  ldb-tools                         <none>
ii  openbsd-inetd [inet-superserver]  0.20091229-2
ii  smbldap-tools                     0.9.7-1+deb7u1
pn  winbind                           <none>

-- Configuration Files:
/etc/init.d/samba changed:
set -e
case $1 in
	start)
		/etc/init.d/nmbd start
		/etc/init.d/smbd start
		;;
	stop)
		/etc/init.d/smbd stop
		/etc/init.d/nmbd stop
		;;
	reload)
		/etc/init.d/smbd reload
		;;
	restart|force-reload)
		/etc/init.d/nmbd "$1"
		/etc/init.d/smbd "$1"
		;;
	status)
		status=0
		NMBD_DISABLED=`testparm -s --parameter-name='disable netbios'
2>/dev/null || true`
		if [ "$NMBD_DISABLED" != "Yes" ]; then
			/etc/init.d/nmbd status || status=$?
		fi
		/etc/init.d/smbd status || status=$?
		exit $status
		;;
	*)
		echo "Usage: /etc/init.d/samba
{start|stop|reload|restart|force-reload|status}"
		exit 1
		;;
esac


-- debconf information:
  samba/run_mode: daemons
  samba-common/title: