[Pkg-samba-maint] [samba] 01/01: abort if tdb move can't be done on upgrade

[Ivo De Decker]

Hi Steve,

On Mon, Oct 21, 2013 at 04:31:55PM -0700, Steve Langasek wrote:
> This code is not idempotent.  If two of the files are moved, and the third
> one fails, then someone (incorrectly) restarts smbd on the system, the first
> two files may be recreated, causing even more failures.
> 
> Do all the checks first, then do all the moves in a separate pass.

OK. Makes sense.

> But I don't know why you're committing this anyway, when we're still
> discussing whether to keep the upstream location for these files.

While we're discussing this, I think it's better to have a clear error instead
of silent failure. Also, having an error might give a better indication about
what's going wrong: are the duplicate files leftovers from issues some time
ago, or are they created during the upgrade. And having this check is in no
way worse than what is in 2:4.0.10+dfsg-2.

As I said before, this doesn't mean I think this is the end of the discussion.
If possible, we should try to follow upstream. But if it turns out we can't
get the migration to work correctly, there might be no other option than to
revert the change and move back to /var/lib/samba. However, even in that case
we should make sure this happens correctly.

Cheers,

Ivo