[Pkg-samba-maint] Patches in the 4.0 package

[Ivo De Decker]

On Sat, Aug 17, 2013 at 08:16:34PM +0200, Jeroen Dekkers wrote:
> I was looking at the patches that are currently in git and I am not
> sure whether we still need these two:
> 
> 05_share_ldb_module
> 
> It disables ldb share module to prevent circular dependencies
> according to the git history. Is that still a problem?
> (http://anonscm.debian.org/gitweb/?p=pkg-samba/samba4.git;a=commit;h=3cc727913e0871fa1538901d3b186f1b9949a2c1)
> 
> 10_messaging_subsystem
> 
> It turns messaging subsystem into a public library, I can't find a
> reason for doing so in the git history. It seems to me that if
> upstream considers it private, we shouldn't make it a public
> library. And if there is a good reason we should document that in the
> patch.

Jeroen,

Did you look in the bzr history of the samba4 package?

I don't really know the answer to both questions, but you could add a note to
each of these patches, so that your remark is visible to people reviewing the
patches in the future.

Cheers,

Ivo