[Pkg-samba-maint] [samba] 02/135: smbd: Fix a talloc hierarchy problem in msg_channel

Ivo De Decker ivodd at moszumanska.debian.org
Sat Jan 11 21:30:21 UTC 2014


This is an automated email from the git hooks/post-receive script.

ivodd pushed a commit to branch master
in repository samba.

commit 3c83eaadb6b8c121fbb604ca45b1d5dd0bc3f51e
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Nov 14 21:30:49 2013 +0100

    smbd: Fix a talloc hierarchy problem in msg_channel
    
    When tearing down a watch_send with an open tevent_immediate, we
    talloc_free the msg_channel while the tevent_immediate still references
    it. Don't make the tevent_immediate outlive the msg_channel.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10250
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Nov 20 00:13:51 CET 2013 on sn-devel-104
    (cherry picked from commit 2d91577f984bc83c2c87141cfdda87d068060b32)
---
 source3/lib/msg_channel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/lib/msg_channel.c b/source3/lib/msg_channel.c
index 537b162..625d07c 100644
--- a/source3/lib/msg_channel.c
+++ b/source3/lib/msg_channel.c
@@ -244,7 +244,7 @@ struct tevent_req *msg_read_send(TALLOC_CTX *mem_ctx,
 
 	num_msgs = talloc_array_length(channel->msgs);
 	if (num_msgs != 0) {
-		im = tevent_create_immediate(channel->ev);
+		im = tevent_create_immediate(channel);
 		if (tevent_req_nomem(im, req)) {
 			return tevent_req_post(req, ev);
 		}

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-samba/samba.git




More information about the Pkg-samba-maint mailing list