[Pkg-samba-maint] Bug#735524: samba: Unbounded per-client logging

[Matthew Gabeler-Lee]

Package: samba
Version: 2:4.1.3+dfsg-2
Severity: minor

Debian's default smb.conf has the directive log file = /var/log/samba/log.%m
which is all well and good.  But, other than log.smbd and log.nmbd, none of
these are rotated or pruned.

In the "old" days, this never seemed to be a problem, but in modern days of
tablets (with apps with CIFS implementations that use a different hostname
every time they launch) and IPv6 (with randomly selected privacy addresses),
I find that this is causing this directory to grow, at least in number of
files, wildly.

I see two sensible options:

1) Adjust the logrotate configuration to rotate /var/log/samba/log.*, remove
the notifempty, and add nocreate.

2) Add a tmpreaper script that will remove old per-client logs after some
reasonable period of time, with appropriate options so that it doesn't eat
the main server log files and their rotation history.

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12-1-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages samba depends on:
ii  adduser             3.113+nmu3
ii  dpkg                1.17.5
ii  libasn1-8-heimdal   1.6~git20131117+dfsg-3
ii  libbsd0             0.6.0-1
ii  libc6               2.17-97
ii  libcomerr2          1.42.9-2
ii  libhdb9-heimdal     1.6~git20131117+dfsg-3
ii  libkdc2-heimdal     1.6~git20131117+dfsg-3
ii  libkrb5-26-heimdal  1.6~git20131117+dfsg-3
ii  libldb1             1:1.1.16-1
ii  libpam-modules      1.1.3-9
ii  libpam-runtime      1.1.3-9
ii  libpopt0            1.16-8
ii  libpython2.7        2.7.6-4
ii  libroken18-heimdal  1.6~git20131117+dfsg-3
ii  libtalloc2          2.1.0-1
ii  libtdb1             1.2.12-1
ii  libtevent0          0.9.19-1
ii  lsb-base            4.1+Debian12
ii  multiarch-support   2.17-97
ii  procps              1:3.3.4-2
ii  python              2.7.5-5
ii  python-dnspython    1.11.1-1
ii  python-ntdb         1.0-2
ii  python-samba        2:4.1.3+dfsg-2
pn  python2.7:any       <none>
ii  samba-common        2:4.1.3+dfsg-2
ii  samba-common-bin    2:4.1.3+dfsg-2
ii  samba-dsdb-modules  2:4.1.3+dfsg-2
ii  samba-libs          2:4.1.3+dfsg-2
ii  tdb-tools           1.2.12-1
ii  update-inetd        4.43

Versions of packages samba recommends:
pn  attr               <none>
ii  logrotate          3.8.6-1
pn  samba-vfs-modules  <none>

Versions of packages samba suggests:
pn  bind9          <none>
pn  bind9utils     <none>
pn  ctdb           <none>
pn  ldb-tools      <none>
ii  ntp            1:4.2.6.p5+dfsg-3
pn  smbldap-tools  <none>
pn  winbind        <none>

-- Configuration Files:
/etc/logrotate.d/samba changed [not included]

-- debconf information excluded