[Pkg-samba-maint] Bug#741492: samba: all process have same title (setproctitle not working)

[Andrew Bartlett]

On Wed, 2014-03-12 at 19:22 -0500, Jeffrey Clark wrote:
> Package: samba
> Version: 2:4.1.5+dfsg-1
> Severity: minor
> Tags: upstream patch
> 
> Dear Maintainer,
> 
> Process titles remain the same as the parent even though libbsd and
> and setproctitle support are correctly detected during package build.
> 
> Additionally log.samba contains a number of ominous messages:
> samba: setproctitle not initialized, please either call setproctitle_init() or link against libbsd-ctor.
> 
> Attached patch completes the setproctitle support when using libbsd.
> There may be a way to link libbsd-ctor.a and elminiate the extra defines,
> but my wscript foo is lacking.
> 
> without attached patch:
> 
> 24650 ?        Ss     0:00 /usr/sbin/samba -D
> 24661 ?        S      0:00  \_ /usr/sbin/samba -D
> 24663 ?        Ss     0:00  |   \_ /usr/sbin/smbd -D --option=server role check:inhibit=yes --foreground
> 24715 ?        S      0:00  |       \_ /usr/sbin/smbd -D --option=server role check:inhibit=yes --foreground
> 28724 ?        S      0:00  |       \_ /usr/sbin/smbd -D --option=server role check:inhibit=yes --foreground
> 24662 ?        S      0:00  \_ /usr/sbin/samba -D
> 24664 ?        S      0:00  \_ /usr/sbin/samba -D
> 24665 ?        S      0:00  \_ /usr/sbin/samba -D
> 24666 ?        S      0:00  \_ /usr/sbin/samba -D
> 24667 ?        S      0:00  \_ /usr/sbin/samba -D
> 24668 ?        S      0:00  \_ /usr/sbin/samba -D
> 24669 ?        S      0:00  \_ /usr/sbin/samba -D
> 24670 ?        S      0:00  \_ /usr/sbin/samba -D
> 24671 ?        S      0:00  \_ /usr/sbin/samba -D
> 24672 ?        S      0:00  \_ /usr/sbin/samba -D
> 24673 ?        S      0:00  \_ /usr/sbin/samba -D
> 24676 ?        S      0:00  \_ /usr/sbin/samba -D
> 
> with attached patch:
> 
>  9660 ?        Ss     0:00 /usr/sbin/samba -D
>  9697 ?        S      0:00  \_ samba: task[s3fs_parent]
>  9699 ?        Ss     0:00  |   \_ /usr/sbin/smbd -D --option=server role check:inhibit=yes --foreground
> 10126 ?        S      0:00  |       \_ /usr/sbin/smbd -D --option=server role check:inhibit=yes --foreground
>  9698 ?        S      0:00  \_ samba: task[dcesrv]
>  9700 ?        S      0:00  \_ samba: task[nbtd]
>  9701 ?        S      0:00  \_ samba: task wrepl server_id[9701]
>  9702 ?        S      0:00  \_ samba: task[ldapsrv]
>  9703 ?        S      0:00  \_ samba: task[cldapd]
>  9704 ?        S      0:00  \_ samba: task[kdc]
>  9706 ?        S      0:00  \_ samba: task[dreplsrv]
>  9709 ?        S      0:00  \_ samba: task[winbind]
>  9710 ?        S      0:00  \_ samba: task[ntp_signd]
>  9714 ?        S      0:00  \_ samba: task[kccsrv]
>  9715 ?        S      0:00  \_ samba: task[dnsupdate]
>  9716 ?        S      0:00  \_ samba: task[dns]

See samba-tool processes for another way to list it.  

The issue I have with the patch is that it introduces a non-standard
3-argument main, and I still remain spooked by what libbsd does inside
it's setproctitle. 

I would actually prefer we stopped looking for setproctitle in libbsd. 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba