[Pkg-samba-maint] Bug#807331: samba: Fails to build from source when not being able to download docbook.xsl

[John Paul Adrian Glaubitz]

Package: samba
Version: 2:4.1.21+dfsg-2
Severity: serious
Justification: fails to build from source (sometimes)

Hello!

The samba package fails to build from source when it can't download the external
stylesheet docbook.xsl which is downloaded from sourceforge.net:

Checking for stylesheet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl : not found

and consequently won't build the manpages which then results in:

#Remove unused vfstest manpage as there is no more vfstest apparently
rm /<<BUILDDIR>>/samba-4.1.21+dfsg/debian/tmp/usr/share/man/man1/vfstest.1
rm: cannot remove '/<<BUILDDIR>>/samba-4.1.21+dfsg/debian/tmp/usr/share/man/man1/vfstest.1': No such file or directory
debian/rules:93: recipe for target 'override_dh_install' failed
make[1]: *** [override_dh_install] Error 1
make[1]: Leaving directory '/<<BUILDDIR>>/samba-4.1.21+dfsg'
debian/rules:69: recipe for target 'binary' failed
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2

I'm not sure why exactly the download of the stylesheet fails. It fails on the
sparc64 and x32 buildds and on my personal sbuild amd64 chroot, all of them
are up-to-date. Since I can download the stylesheet from the very same machine
I am using for amd64 builds:

glaubitz at z6:~> wget http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
--2015-12-07 14:51:42--  http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl
Resolving docbook.sourceforge.net (docbook.sourceforge.net)... 216.34.181.96
Connecting to docbook.sourceforge.net (docbook.sourceforge.net)|216.34.181.96|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 15230 (15K) [application/xslt+xml]
Saving to: ‘docbook.xsl’

docbook.xsl                        100%[==================================================================>]  14.87K  64.5KB/s   in 0.2s   

2015-12-07 14:51:50 (64.5 KB/s) - ‘docbook.xsl’ saved [15230/15230]

glaubitz at z6:~>

it must be some extra sbuild/schroot configuration or additional package that the samba build
scripts rely on to be able to download the stylesheet. However, I think it's generally
bad when a package in Debian can no longer be build from source just because a file on
a third party server is missing or corrupted. That being said, I think it's also a
potential security problem when the buildds blindly download files from third party
servers.

Cheers,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913