[Pkg-samba-maint] debian-only patches break upgrading our python3 bindings (was: Re: Bug#814928: build python3 bindings)

[Jelmer Vernooij]

On Mon, Apr 04, 2016 at 09:08:25AM +1200, Andrew Bartlett wrote:
> On Sun, 2016-04-03 at 20:44 +0000, Jelmer Vernooij wrote:
> 
> > Mostly LGTM. Please add a dot after each sentence in the changelogs.
> 
> Thanks.  Fixed.
> 
> > I don't think it's fair to say that reverting the symbols patch is
> > breaking the symbols. The symbols are broken by design as they
> > include
> > the upstream version string, meaning each new version will change the
> > names of all symbols:
> > 
> > E.g.:
> > 
> > + pytalloc_reference_ex at PYTALLOC_UTIL.PY3_2.1.5 2.1.6
> > 
> > (notice the _2.1.5 at the end of the symbol name)
> 
> That looks OK to me.  In this case it is odd, because the .PY3_2.1.5
> symbol first appears in our new 2.1.6 package.  
> 
> The next version will, like the python2 package, only add the name of
> new symbols.
> 
> With the patch I removed in place however, it did do what you say: 
> 
> Each new talloc version broke all the symbols, as no old version
> numbers were embedded in the symbols.  
> 
> (The fact that 2.1.5 and 2.1.6, and -py3 and .py3 are visually similar
> makes this all the more mind-bending).
Ah, oops. I missed the @ in there for some reason.

Looks okay to upload for me.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20160403/3137c6d9/attachment.sig>