[Pkg-samba-maint] selftest failing on Debian packages

[Andrew Bartlett]

On Tue, 2016-04-05 at 20:53 +1200, Andrew Bartlett wrote:
> On Tue, 2016-04-05 at 05:48 +0200, Mathieu Parent wrote:
> > Hello,
> > 
> > I'm preparing a patch to samba to add a "selftest" build profile.
> > 
> > I can already say that selftest is failing. I'm running it again as
> > root as it may fix some of them (on my very slow computer).
> 
> This shouldn't be required.
> 
> > - 0001-Add-a-selftest-build-profile.patch: The patch I'm going to
> > merge (needs small refactoring)
> > - 0002-selftest-builddeps.patch: the remaining part, to merge once
> > wheezy is EOL (it doesn't support build profiles). Or we can merge
> > it
> > and drop those lines while backporting.
> > - 0003-usershare.patch-Fix-usershare-max-shares-default-in-.patch::
> > first patch to fix the selftest
> > 
> > and the build log (without python-testscenarios installed).
> > 
> > Can you look at the failures?
> 
> Eventually, we shouldn't need a distinct profile for this, at least
> for
> performance reasons.  That is, we may be able to get this to work in
> the main profile - the selftest used socket_wrapper et al, but this
> is
> no longer compiled in, they LD_PRELOAD.

While this statement is correct, I would note that --enable-selftest
does impact on the main build in another way:  Currently, it
reintroduces the ntvfs file server.

Sadly that means we need to push selftest back into a build profile
until that is sorted, because we don't want the ntvfs file server
leaking into a stable release.

In the meantime, we need to move Samba's main selftest away from
running against that file server, and then have it skip such tests when
it is not built, rather than silently enabling it. 

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba