[Pkg-samba-maint] Bug#838796: samba: logrotate for log.smbd is too verbose when samba is not running

[Roland Hieber]

Package: samba
Version: 2:4.4.5+dfsg-3
Severity: minor
Tags: patch

Dear Maintainer,

I have disabled the smbd process on my system, but now the daily logrotate bugs
me that it cannot restart the smbd daemon via /etc/init.d/smbd reload:

	/etc/cron.daily/logrotate:
	smbd.service is not active, cannot reload.
	error: error running non-shared postrotate script for /var/log/samba/log.smbd of '/var/log/samba/log.smbd '
	run-parts: /etc/cron.daily/logrotate exited with return code 1


This patch does the job for me:

-------------------------------------- 8< --------------------------------------
--- /etc/logrotate.d/samba.orig	2016-09-25 01:18:34.896469400 +0200
+++ /etc/logrotate.d/samba	2016-09-25 01:18:39.612429939 +0200
@@ -3,7 +3,7 @@
 	missingok
 	rotate 7
 	postrotate
-		/etc/init.d/smbd reload > /dev/null
+		[ ! -f /var/run/samba/smbd.pid ] || /etc/init.d/smbd reload > /dev/null
 	endscript
 	compress
 	notifempty
-------------------------------------- >8 --------------------------------------


Cheers,
 - Roland

-- System Information:
Debian Release: stretch/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (500, 'stable'), (170, 'unstable'), (1, 'unstable-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages samba depends on:
ii  adduser              3.115
ii  dpkg                 1.18.10
ii  init-system-helpers  1.44
ii  libbsd0              0.8.3-1
ii  libc6                2.23-5
ii  libldb1              2:1.1.26-1
ii  libpam-modules       1.1.8-3.3
ii  libpam-runtime       1.1.8-3.3
ii  libpopt0             1.16-10
ii  libpython2.7         2.7.12-3
ii  libtalloc2           2.1.7-1
ii  libtdb1              1.3.9-1
ii  libtevent0           0.9.28-1
ii  libwbclient0         2:4.4.5+dfsg-3
ii  lsb-base             9.20160629
ii  procps               2:3.3.12-2
ii  python               2.7.11-2
ii  python-dnspython     1.14.0-3
ii  python-samba         2:4.4.5+dfsg-3
pn  python2.7:any        <none>
ii  samba-common         2:4.4.5+dfsg-3
ii  samba-common-bin     2:4.4.5+dfsg-3
ii  samba-libs           2:4.4.5+dfsg-3
ii  tdb-tools            1.3.9-1
ii  update-inetd         4.43

Versions of packages samba recommends:
pn  attr                <none>
ii  logrotate           3.8.7-2
ii  samba-dsdb-modules  2:4.4.5+dfsg-3
pn  samba-vfs-modules   <none>

Versions of packages samba suggests:
pn  bind9          <none>
pn  bind9utils     <none>
pn  ctdb           <none>
pn  ldb-tools      <none>
ii  ntp            1:4.2.8p8+dfsg-1
pn  smbldap-tools  <none>
pn  ufw            <none>
pn  winbind        <none>

-- debconf information:
  samba/run_mode: daemons
  samba-common/title: