[Pkg-samba-maint] Bug#881353: smb.conf: client max protocol = default limits connections to SMB1

[wolfgang]

Package: samba-common
Version: 2:4.5.12+dfsg-2
Severity: normal

Dear Maintainer,

I was trying to access the shares on my LibreELEC box which was recently upgraded to v8.2.0.
This upgrade disabled SMB1 support on LibreELEC. Trying to access the shares with Thunar
gave me a "Failed to retrieve share list from server" error.

Running "smbclient -L libreelec" shows:
protocol negotiation failed: NT_STATUS_INVALID_NETWORK_RESPONSE

After some research I think I found the problem:
In smb.conf the option 'client max protocol' is not set (and according to the smb.conf man page it shouldn't be).

"testparm -v | grep protocol" shows:

	client ipc max protocol = default
	client ipc min protocol = default
	client max protocol = default
	client min protocol = CORE
	server max protocol = SMB3
	server min protocol = LANMAN1


According to the man page: "The value default refers to NT1."
AFAIK NT1 means SMB1, so the default setting limits the client to SMB1.
And if the server doesn't support SMB1 the connection doesn't work.

A soulution is to set "client max protocol = SMB3" in /etc/samba/smb.conf (or in ~/.smb/smb.conf.append).
However this only works if samba-common is installed. In my case it wasn't installed.
I think Thunar doesn't need it since it uses libsmbclient.

So for network shares to work out of the box I think this needs to be fixed, ideally in a way
that makes libsmbclient work without the need for /etc/samba/smb.conf (samba-common).


-- System Information:
Debian Release: 9.1
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-4-amd64 (SMP w/12 CPU cores)
Locale: LANG=de_LU.utf8, LC_CTYPE=de_LU.utf8 (charmap=UTF-8), LANGUAGE=de_LU:de (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages samba-common depends on:
ii  debconf [debconf-2.0]  1.5.61
ii  dpkg                   1.18.24
ii  ucf                    3.0036

Versions of packages samba-common recommends:
ii  samba-common-bin  2:4.5.12+dfsg-2

samba-common suggests no packages.

-- debconf information excluded