[Pkg-samba-maint] Bug#909465: Upgrade samba fails if winbind is install with default config

[L.P.H. van Belle]

Hai, 
 
I have an update on this and created working package without startup problems.
 
i've added in the samba-common.postinst the following part at the end just before #DEBHELPER# 
 
# Test server role and change smb.conf to enable idmap * by default.
SERVER_ROLE=`samba-tool testparm --parameter-name="server role"  2>/dev/null | tail -1`

# Enable idmap config * by default. Only match untouched configs.
if [ "$SERVER_ROLE" = "standalone server" ] || [ "$SERVER_ROLE" = "auto" ]; then
    sed -i \
    -e 's/;   idmap config \* :              backend = tdb/    idmap config * :              backend = tdb/g' \
    -e 's/;   idmap config \* :              range   = 3000-7999/    idmap config * :              range   = 3000-7999/g' \
    "$CONFIG"
fi

 
The sed command might need some improvement here, but this allow a flawless install. 
Upgrade from a 4.8.5 also worked fine for me, its tested by users off the sambalist now. 
 
Thoughts of this are. 
 
- a new install used the smb.conf and the change is applied.
    and all services are starting as they should 
- a old install with the defaults intact gets the changes also.
    and all services are starting as they should 
- any modified smb.conf where idmap is already enabled isnt applied. 
    you must manual change smb.conf. 
- it only applies to the standalone server

 
This is imo a good workaround until this bug is fixed in samba for the new/upgrade installations
As posted in the previous message. the other is 
net groupmap add sid=S-1-5-32-546 unixgroup=nogroup type=builtin
 Note, the previous mesasge had nobody as group, should be nogroup.
 
 
Greetz, 
 
Louis