[Pkg-samba-maint] Bug#912340: Bug#912340: [src:samba]: Unreproducible on sid

[Andrew Bartlett]

On Tue, 2018-10-30 at 16:43 +0100, Mathieu Parent wrote:
> Source: samba
> Version: 2:4.6.5+dfsg-6
> Tags: patch
> User: reproducible-builds at lists.alioth.debian.org
> Usertags: buildpath
> X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org
> 
> Hi,
> 
> Since https://salsa.debian.org/samba-team/samba/commit/c7628ec63c8372c9d3a73d51a0d4a8401f9a1f8e,
> samba FTBR.
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/samba.html
> has:
> 
>     Expands build prefix variables in smb.conf.5 but curiously only
> three of the variables are expanded, not all of them...
> 
> I will try the following patch:
> 
> diff --git a/dynconfig/wscript b/dynconfig/wscript
> index 54977e42bd4..008a1942a46 100644
> --- a/dynconfig/wscript
> +++ b/dynconfig/wscript
> @@ -365,7 +365,6 @@ def get_override(bld):
>                   'BINDIR'        : 'bin',
>                   'SBINDIR'       : 'bin',
>                   'CODEPAGEDIR'   : 'codepages',
> -                 'SCRIPTSBINDIR' : 'source4/scripting/bin',
>                   'SETUPDIR'      : 'source4/setup'
>                   }
>      return override

As long as you are happy for make test to fail, that will be OK.

For reasons I couldn't track down, waf doesn't realise the dependency
has changed for the xml manpage generation so doesn't rebuild the
manpages.

I filed this bug https://bugzilla.samba.org/show_bug.cgi?id=13198

waf has changed a lot for 4.10 so the first step would be to double-
check master. 

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba