[Pkg-samba-maint] Bug#946821: winbind: Broken logrotate script

[Sven Geggus]

Package: winbind
Version: 2:4.9.5+dfsg-5+deb10u1
Severity: normal
Tags: patch

Hello,

I'm running Samba/Winbind on a dual Host setup (using drbd) where winbind is
running only on the currently active machine.

Unfortunately /etc/logrotate.d/winbind assumes that winbind is always
running which will produce weekly logrotate errors on the passive machine.

For this reason I propose the following change:

--cut--
diff --git a/logrotate.d/winbind b/logrotate.d/winbind
index 43ae1af..21084e6 100644
--- a/logrotate.d/winbind
+++ b/logrotate.d/winbind
@@ -3,10 +3,12 @@
        missingok
        rotate 7
        postrotate
-               if [ -x /usr/bin/smbcontrol ]; then
-                       /usr/bin/smbcontrol winbindd reload-config
-               elif [ -f /var/run/samba/winbindd.pid ]; then
-                       kill -HUP `cat /var/run/samba/winbindd.pid`
+               if [ -f /var/run/samba/winbindd.pid ]; then
+                       if [ -x /usr/bin/smbcontrol ]; then
+                               /usr/bin/smbcontrol winbindd reload-config
+                       else
+                               kill -HUP `cat /var/run/samba/winbindd.pid`
+                       fi
                fi
        endscript
        compress
--cut--

Regards

Sven

P.S.: Problem is still present in 2:4.11.1+dfsg-3

-- Package-specific info:
* /etc/samba/smb.conf present, but not attached
* /var/lib/samba/dhcp.conf not present

-- System Information:
Debian Release: 10.2
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-6-amd64 (SMP w/32 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages winbind depends on:
ii  libbsd0           0.9.1-2
ii  libc6             2.28-10
ii  libldap-2.4-2     2.4.47+dfsg-3+deb10u1
ii  libpopt0          1.16-12
ii  libtalloc2        2.1.14-2
ii  libtdb1           1.3.16-2+b1
ii  libtevent0        0.9.37-1
ii  libwbclient0      2:4.9.5+dfsg-5+deb10u1
ii  lsb-base          10.2019051400
ii  samba-common      2:4.9.5+dfsg-5+deb10u1
ii  samba-common-bin  2:4.9.5+dfsg-5+deb10u1
ii  samba-libs        2:4.9.5+dfsg-5+deb10u1

winbind recommends no packages.

Versions of packages winbind suggests:
pn  libnss-winbind  <none>
pn  libpam-winbind  <none>

-- Configuration Files:
/etc/logrotate.d/winbind changed [not included]

-- no debconf information