[Pkg-samba-maint] Bug#931734: samba-common-bin.postinst fails when role is ad-dc and ldb backend is used

[Gernot Schilling]

Package: samba-common-bin
Version: 2:4.9.11+dfsg-1
Severity: normal

Dear Maintainer,

* What led up to the situation?

upgrade from stretch to buster

* What exactly did you do (or not do) that was effective (or ineffective)?
  
diverted testparm and replaced it with script that called 
"samba-tool testparm"   

the postinst checks for role of samba _after_ a plain testparm call
which fails because it is not supposed to be used on ad-dc

https://bugzilla.samba.org/show_bug?id=12629#c7
(last comment)

this diff should fix the problem: 


--- samba-common-bin.postinst	2019-07-08 09:56:36.000000000 +0200
+++ samba-common-bin.postinst.fixed	2019-07-09 21:11:49.284682976 +0200
@@ -2,15 +2,15 @@
 
 set -e
 
-echo "Checking smb.conf with testparm"
-testparm -d1 --suppress-prompt > /dev/null
-echo "Done"
-
 SERVER_ROLE=`samba-tool testparm --parameter-name="server role"  2>/dev/null | tail -1`
 if [ "$SERVER_ROLE" = "active directory domain controller" ]; then
     echo "Checking smb.conf with samba-tool"
     samba-tool testparm -d1 --suppress-prompt > /dev/null
     echo "Done"
+else
+    echo "Checking smb.conf with testparm"
+    testparm -d1 --suppress-prompt > /dev/null
+    echo "Done"
 fi
 

* What was the outcome of this action?

configuration of samba packages failed.

* What outcome did you expect instead?

samba packages configured and installed ok


-- System Information:
Debian Release: 10.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-6-amd64 (SMP w/1 CPU core)
Kernel taint flags: TAINT_FORCED_RMMOD
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages samba-common-bin depends on:
ii  libbsd0        0.9.1-2
ii  libc6          2.28-10
ii  libldap-2.4-2  2.4.47+dfsg-3
ii  libncurses6    6.1+20181013-2
ii  libpopt0       1.16-12
ii  libreadline8   8.0-2
ii  libtalloc2     2.1.14-2
ii  libtdb1        1.3.16-2+b1
ii  libtevent0     0.9.37-1
ii  libtinfo6      6.1+20181013-2
ii  libwbclient0   2:4.9.11+dfsg-1
ii  python         2.7.16-1
ii  python-samba   2:4.9.11+dfsg-1
ii  python2.7      2.7.16-2
ii  samba-common   2:4.9.11+dfsg-1
ii  samba-libs     2:4.9.11+dfsg-1

Versions of packages samba-common-bin recommends:
ii  samba-dsdb-modules  2:4.9.11+dfsg-1

Versions of packages samba-common-bin suggests:
pn  heimdal-clients  <none>

-- no debconf information