[Pkg-samba-maint] Bug#928864: samba: please update systemd units to refer to /run, not /var/run

[Simon McVittie]

Source: samba
Version: 2:4.9.5+dfsg-3
Severity: minor

systemd in buster logs a warning on each `systemctl daemon-reload` when
units refer to a PID file in /run via the compatibility symlink /var/run:

May 12 09:37:20 sentinel systemd[1]: /lib/systemd/system/smbd.service:9: PIDFile= references path below legacy directory /var/run/, updating /var/run/samba/smbd.pid → /run/samba/smbd.pid; please update the unit file accordingly.
May 12 09:37:20 sentinel systemd[1]: /lib/systemd/system/nmbd.service:9: PIDFile= references path below legacy directory /var/run/, updating /var/run/samba/nmbd.pid → /run/samba/nmbd.pid; please update the unit file accordingly.

Please use /run/samba/smbd.pid and /run/samba/nmbd.pid instead. I can
confirm that the obvious edit to /lib/systemd/system/?mbd.service
stops the warning. I believe this corresponds to changing
--with-piddir=/run/samba to --with-piddir=/var/run/samba in debian/rules.

/var/run is guaranteed to be a compatibility symlink to /run on all
post-2012 Debian systems, whether they were booted with systemd or not.
Policy §9.1.1.8 requires this, and sysvinit (>= 2.88dsf-29) ensures
that it is the case.

Thanks,
    Simon

-- Package-specific info:
* /etc/samba/smb.conf present, but not attached
* /var/lib/samba/dhcp.conf not present

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages samba depends on:
ii  adduser           3.118
ii  dpkg              1.19.6
ii  libbsd0           0.9.1-2
ii  libc6             2.28-10
ii  libldb1           2:1.5.1+really1.4.6-3
ii  libpam-modules    1.3.1-5
ii  libpam-runtime    1.3.1-5
ii  libpopt0          1.16-12
ii  libpython2.7      2.7.16-2
ii  libtalloc2        2.1.14-2
ii  libtdb1           1.3.16-2+b1
ii  libtevent0        0.9.37-1
ii  lsb-base          10.2019031300
ii  procps            2:3.3.15-2
ii  python            2.7.16-1
ii  python-dnspython  1.16.0-1
ii  python-samba      2:4.9.5+dfsg-3
ii  python2.7         2.7.16-2
ii  samba-common      2:4.9.5+dfsg-3
ii  samba-common-bin  2:4.9.5+dfsg-3
ii  samba-libs        2:4.9.5+dfsg-3
ii  tdb-tools         1.3.16-2+b1

Versions of packages samba recommends:
ii  attr                1:2.4.48-4
ii  logrotate           3.14.0-4
ii  samba-dsdb-modules  2:4.9.5+dfsg-3
ii  samba-vfs-modules   2:4.9.5+dfsg-3

Versions of packages samba suggests:
pn  bind9          <none>
pn  bind9utils     <none>
pn  ctdb           <none>
pn  ldb-tools      <none>
pn  ntp | chrony   <none>
pn  smbldap-tools  <none>
pn  ufw            <none>
pn  winbind        <none>

-- no debconf information