[Pkg-samba-maint] Bug#940697: samba: Please disable cephfs support on architectures where it's not stable

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Thu Sep 19 08:16:22 BST 2019


Source: samba
Version: 2:4.10.8+dfsg-1
Severity: normal
Tags: patch
User: debian-68k at lists.debian.org
Usertags: m68k

Hello!

samba currently fails to build from source on multiple architectures either
because support for cephfs is not stable on these architectures or currently
not available at all [1].

I therefore suggest to make support for cephfs conditional per architecture
so it can be enabled on architectures only where we know it works reliably.

Attaching a proposed debdiff.

Thanks,
Adrian

> [1] https://buildd.debian.org/status/package.php?p=samba&suite=unstable

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
-------------- next part --------------
diff -Nru old/samba-4.10.8+dfsg/debian/control new/samba-4.10.8+dfsg/debian/control
--- old/samba-4.10.8+dfsg/debian/control	2019-09-10 18:32:08.000000000 +0200
+++ new/samba-4.10.8+dfsg/debian/control	2019-09-19 09:08:42.385884902 +0200
@@ -23,7 +23,7 @@
                libblkid-dev,
                libbsd-dev,
                libcap-dev [linux-any],
-               libcephfs-dev [linux-any],
+               libcephfs-dev [amd64 arm64 i386 mips64el ppc64el ppc64 x32],
                libcmocka-dev (>= 1.1.3),
                libcups2-dev,
                libdbus-1-dev,
diff -Nru old/samba-4.10.8+dfsg/debian/rules new/samba-4.10.8+dfsg/debian/rules
--- old/samba-4.10.8+dfsg/debian/rules	2019-09-10 18:32:08.000000000 +0200
+++ new/samba-4.10.8+dfsg/debian/rules	2019-09-19 09:08:17.445884240 +0200
@@ -70,12 +70,19 @@
 		--with-logdir=/var/log/ctdb \
 		--enable-etcd-reclock
 
+ifeq (,$(filter amd64 arm64 i386 mips64el ppc64el ppc64 x32, $(DEB_HOST_ARCH)))
+        conf_args += \
+                --enable-ceph-reclock
+else
+        conf_args += \
+                --disable-cephfs
+endif
+
 ifeq ($(DEB_HOST_ARCH_OS), linux)
 	conf_args += \
 		--with-systemd \
 		--systemd-install-services \
-		--with-systemddir=/lib/systemd/system \
-		--enable-ceph-reclock
+		--with-systemddir=/lib/systemd/system
 else
 	conf_args += \
 		--without-systemd


More information about the Pkg-samba-maint mailing list