[Pkg-samba-maint] Few small questions.

[Mathieu Parent]

(NB: I've added the ML as CC)

Le mer. 18 sept. 2019 à 09:26, L.P.H. van Belle <belle at bazuin.nl> a écrit :
>
> Good Morning Mathieu,

Good morning,

> You going fast on the new builds.. Fantastic job..
> Im compairing my work now to your changes.
> I was a bit ahead on this, i try to do that so i can see and learn from your changes.

I can learn too ;-)

> A few small questions if i may.
> I noticed in wscript that asn1 is used ( or is available as option )
>
> But we dont use the debian supplied libtasn1-6-dev ?
> ( from :
>     if check_system_heimdal_lib("krb5", "krb5_anyaddr", "krb5.h",
>         onlyif="roken wind asn1 hx509 hcrypto com_err heimbase"):
> )

libtasn1-6-dev is transitively installed, but not libtasn1-bin:
< Selecting previously unselected package libtasn1-6-dev:amd64.^M
< Preparing to unpack .../130-libtasn1-6-dev_4.14-3_amd64.deb ...^M
< [...]
< Checking for system libtasn1 (>=3.8)
                           : 19:39:29 runner ['/usr/bin/pkg-config',
'libtasn1 >= 3.8', '--cflags', '--libs', 'libtasn1']
< yes
< Checking for program 'asn1Parser'
                           : not found
< WARNING: ans1Parser hasn't been found! Please install it (e.g. libtasn1-bin)

Could you send a MR to explicitly add libtasn1-6-dev (>=3.8) and
libtasn1-bin ? This will add the dumpmscat bin it seems.


> And same for aio-dev

< Checking for header libaio.h                             : 19:37:41
runner ['/usr/bin/gcc', '-D_SAMBA_BUILD_=4', '-DHAVE_CONFIG_H=1',
'-g', '-O2', '-fdebug-prefix-map=/build/samba-4.11.0+dfsg=.',
'-fstack-protector-strong', '-Wformat', '-Werror=format-security',
'-MMD', '-D_GNU_SOURCE=1', '-D_XOPEN_SOURCE_EXTENDED=1',
'../../test.c', '-c',
'-o/build/samba-4.11.0+dfsg/bin/.conf_check_bd93f3a15035a9d07e8eabb154cf05aa/testbuild/default/test.c.1.o',
'-Wdate-time', '-D_FORTIFY_SOURCE=2']
< no
< [...]
< Checking for header aio.h                                : 19:37:46
runner ['/usr/bin/gcc', '-D_SAMBA_BUILD_=4', '-DHAVE_CONFIG_H=1',
'-g', '-O2', '-fdebug-prefix-map=/build/samba-4.11.0+dfsg=.',
'-fstack-protector-strong', '-Wformat', '-Werror=format-security',
'-MMD', '-D_GNU_SOURCE=1', '-D_XOPEN_SOURCE_EXTENDED=1',
'../../test.c', '-c',
'-o/build/samba-4.11.0+dfsg/bin/.conf_check_4c0b007eb741450a054a7dadc5efbc62/testbuild/default/test.c.1.o',
'-Wdate-time', '-D_FORTIFY_SOURCE=2']
< yes

Note that vfs_aio_fork and vfs_aio_pthread are already built, as aio.h
is in libc6-dev. I not sure there is anything to do here (the only
user is source4/ntvfs/posix/pvfs_aio.c).

Also, lib/replace seems to consider that libaio.h and aio.h are
compatible, which is not what
https://stackoverflow.com/questions/8768083/difference-between-posix-aio-and-libaio-on-linux
says.


>
> If i may suggest, or if you want these in a bug report first.

A MR is OK for me (no need for bug report).

> Is it possible to enable timemachine ( spotlight) in the 4.11 packages on Debian.
> A lot of users of my current packages are using spotlight for apple backups.
>
> For that we need in d/control
> 46,48c46
> <                libtevent-dev (>= 0.10.0~),
> <                libtracker-miner-2.0-dev,
> <                libtracker-sparql-2.0-dev,
> ---
> >                libtevent-dev (>= 0.10.0~),
>
> And d/rules
> 71,72c71
> <               --enable-etcd-reclock \
> <               --enable-spotlight
> ---
> >               --enable-etcd-reclock

Please do a MR.

> What i also did, and this is because i notice more and more people are missing the package acl.
> Since acl in AD_DC servers and members is obligate if you use windows acl, i added it to :
> in d/control, Package: samba
> Recommends: acl, attr, logrotate, samba-dsdb-modules, samba-vfs-modules

Is it? libacl is, but acl... Anyway, I'm ok for recommend. Please MR ...

See related #881239, 812e59b880373 c20d4256b60a710.

> One other thing i did see was.
> Package: samba-dev
> Depends: libc6-dev,
>          libldb-dev,
>          libpopt-dev,
>          libtalloc-dev,
>          libtdb-dev (>= 1.2.11),
>
> Is the version here for libtdb-dev not needed to bump up? Or is this set to allow backports and sssd builds. ?

Please MR to bump this to libtdb-dev (>= 2).

> The suggestions here are based on what i did see for build depends here.
> ( from : bootstrap/generated-dists/debian9/packages.yml )
> I do know that this set is to large for debian because these builds are source builds,
> but i try to see what i missed if i missed depends

Some cleaning may be done here too.

> Im wondering about these, why they are not enable in the samba builds.
>
> libaio-dev ( it was enablle in https://packages.debian.org/source/stretch/samba )
> Dropped in 4.8 due to build conflicts.
> But dont we need it for :
> usr/lib/x86_64-linux-gnu/samba/vfs/aio_pthread.so
> usr/lib/x86_64-linux-gnu/samba/vfs/aio_fork.so

No.They use aio.h from libc6-dev.

> libtasn1-dev ( the -bin is pulled with the -dev package )
> I see its included in the build withing : bin/default/source4/heimdal/lib/asn1
> And
> Checking for system libtasn1 (>=3.8)                                              : 21:44:03 runner ['/usr/bin/pkg-config', 'libtasn1 >
> = 3.8', '--cflags', '--libs', 'libtasn1']
> Checking for program 'asn1Parser'                                                 : /usr/bin/asn1Parser
>
See above.

> liblmdb-dev, but doesnt samba not need it enabled while building.

liblmdb-dev is required while building ldb, not samba.


> Sorry for asking so much, but i want to try to stay as close as i can to the official debian builds.
> I working on my git skills atm, so i hope i can do some things for you/Debian also.

No problem, peer review is great!

>
> Best regards,
>
> Louis
>


-- 
Mathieu