[Pkg-samba-maint] 4.11 Results, need some check-ups here.

Fri Sep 20 17:34:09 BST 2019

(please cc the team in the future)

Le ven. 20 sept. 2019 à 10:59, L.P.H. van Belle <belle at bazuin.nl> a écrit :
>
> Hai Matheu,

Hello Louis,

>
> Ok, so that last fix in d/rules IS the solution. i pushed a change for it already.

I don't think so. See below.

> I've shared the build, logs, etc, all is here :  https://apt.van-belle.nl/411-test/
>
> Currently im looking at these lintian output, if things does well, and i hope with last bit of guidance of you to fix the need things from the lintian output.
> I've commented the lines with, what i know, or expect. If you can have a quick look..
>
> --- Lintian output --
> W: samba source: newer-standards-version 4.4.0 (current is 4.3.0)
> i've builded on buster, so ignore this one..

OK

> E: samba: missing-dependency-on-libc needed by usr/bin/dumpmscat and 31 others    ( I dont know, new one for me.)
> - But i would not expected to see this.. Why are we missing libc depends?

This is probably because of your d/rules patch. I don't have those.

> W: samba: binary-without-manpage usr/bin/dumpmscat
> W: samba: binary-without-manpage usr/sbin/samba_dnsupdate
> W: samba: binary-without-manpage usr/sbin/samba_spnupdate
> W: samba: binary-without-manpage usr/sbin/samba_upgradedns
> W: samba: package-has-unnecessary-activation-of-ldconfig-trigger
> - I assume we can ignore these, but dont add it in the ignore files, we want man pages in the end also.

Yes for the missing manpages.

> E: samba-testsuite: missing-dependency-on-libc needed by usr/bin/gentest and 6 others
> - Same as dumpmscat.

Your patch.

> W: samba-testsuite: package-has-unnecessary-activation-of-ldconfig-trigger
> - Ignored..

This one exists for a long time. I don't know how to fix it.(for the
curious : See https://bugs.debian.org/204975)

> E: libsmbclient: missing-dependency-on-libc needed by usr/lib/x86_64-linux-gnu/libsmbclient.so.0.5.0
> - Same as dumpmscat.
>
> E: samba-vfs-modules: missing-dependency-on-libc needed by usr/lib/x86_64-linux-gnu/samba/vfs/acl_tdb.so and 41 others
> - Same as dumpmscat.
>
> E: winbind: missing-dependency-on-libc needed by usr/bin/ntlm_auth and 16 others
> - Same as dumpmscat.
>
> W: winbind: package-has-unnecessary-activation-of-ldconfig-trigger
> - Ignored
>
> W: samba-libs-dbgsym: debug-file-with-no-debug-symbols usr/lib/debug/.build-id/88/f3d507212267b4429bf0a0fcd2961672a2cf56.debug
> - Ignored

This is aes (full of asm) probably.

>
> E: registry-tools: missing-dependency-on-libc needed by usr/bin/regdiff and 3 others
> - Same as dumpmscat.
>
> E: libpam-winbind: missing-dependency-on-libc needed by lib/x86_64-linux-gnu/security/pam_winbind.so
> - Same as dumpmscat.
>
> E: ctdb: missing-dependency-on-libc needed by usr/bin/ctdb and 15 others
> - Same as dumpmscat.
>
> W: ctdb: binary-without-manpage usr/bin/ctdb_local_daemons
> - I assume we can ignore these, but dont add it in the ignore files, we want man pages in the end also.
>
> W: ctdb: package-has-unnecessary-activation-of-ldconfig-trigger
> - Ignored
>
> E: samba-common-bin: missing-dependency-on-libc needed by usr/bin/dbwrap_tool and 5 others
> - Same as dumpmscat.
>
> W: samba-common-bin: manpage-has-errors-from-man usr/share/man/man5/smb.conf.5.gz 3267: warning [p 38, 10.2i]: can't break line
> - Ignored, but maybe i can fix this one, ill have a look at it.

I don't have this one, are you building 4.11.0 ?

> W: samba-common-bin: binary-without-manpage usr/sbin/samba_kcc
> - I assume we can ignore these, but dont add it in the ignore files, we want man pages in the end also.
>
> E: libnss-winbind: missing-dependency-on-libc needed by lib/x86_64-linux-gnu/libnss_winbind.so.2 and 1 others
> - Same as dumpmscat.
>
> E: smbclient: missing-dependency-on-libc needed by usr/bin/cifsdd and 8 others
> - Same as dumpmscat.
>
> W: samba-libs: package-name-doesnt-match-sonames libdcerpc-binding0 libdcerpc-samr0 libdcerpc-server0 libdcerpc0 libndr-krb5pac0 libndr-nbt0 libndr-standard0 libndr0 libnetapi0 libsamba-credentials0 libsamba-errors1 libsamba-hostconfig0 libsamba-passdb0 libsamba-policy.cpython-37m-x86-64-linux-gnu0 libsamdb0 libsmbconf0 libsmbldap2 libtevent-util0
> - Needs updating in lintian igfnore files.

Done in 07da5bb4cc8366160b681c7da6abd3dc7dcd49f9

> W: samba-libs: shared-lib-without-dependency-information usr/lib/x86_64-linux-gnu/samba/libaesni-intel.so.0
> - Ignore, add to .ignore so lintian ignores it?

Good idea (this is full of asm).

> W: samba-libs: missing-depends-line
> - NEEDS FIX

Due to your patch.

>
> E: python3-samba: missing-dependency-on-libc needed by usr/lib/python3/dist-packages/samba/_glue.cpython-37m-x86_64-linux-gnu.so and 59 others
> - Same as dumpmscat.
>
> W: python3-samba: package-has-unnecessary-activation-of-ldconfig-trigger
> - Ignored
>
> E: libwbclient0: missing-dependency-on-libc needed by usr/lib/x86_64-linux-gnu/libsamba-util.so.0.0.1 and 3 others
> - Same as dumpmscat.
>
> W: libwbclient0: dev-pkg-without-shlib-symlink usr/lib/x86_64-linux-gnu/libsamba-util.so.0.0.1 usr/lib/x86_64-linux-gnu/libsamba-util.so
> - I expect NEED FIX

Fixed in the same commit.
>
> E: samba-dsdb-modules: missing-dependency-on-libc needed by usr/lib/x86_64-linux-gnu/samba/ldb/acl.so and 49 others
> - Same as dumpmscat.
>
> W: samba-dev: pkg-config-references-unknown-shared-library usr/lib/x86_64-linux-gnu/pkgconfig/samba-policy.cpython-37m-x86_64-linux-gnu.pc -lsamba-policy (line 11)
> - Ignore.

We need to find the cause for this one.

I  also have those:

# Actionnable :
P: ctdb: command-in-sbin-has-manpage-in-incorrect-section usr/sbin/ctdbd
P: ctdb: command-in-sbin-has-manpage-in-incorrect-section usr/sbin/ctdbd_wrapper

# FTBR
I: samba-testsuite: file-references-package-build-path usr/bin/smbtorture
I: samba-libs: file-references-package-build-path
usr/lib/x86_64-linux-gnu/samba/libsmbd-base.so.0

# Hardening or false-positives?
I: samba-vfs-modules: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/samba/vfs/expand_msdfs.so
I: samba-vfs-modules: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/samba/vfs/fileid.so
I: samba-libs: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/libsamba-policy.cpython-37m-x86-64-linux-gnu.so.0.0.1
I: samba-libs: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/samba/libcli-ldap.so.0
I: samba-libs: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/samba/libsmb-transport.so.0
I: winbind: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/samba/idmap/hash.so
I: winbind: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/samba/idmap/tdb2.so
I: winbind: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/samba/nss_info/hash.so
I: libwbclient0: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/samba/libsys-rw.so.0
I: libnss-winbind: hardening-no-fortify-functions
lib/x86_64-linux-gnu/libnss_winbind.so.2
I: samba: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/samba/libmscat.so.0

#
W: samba-libs: shared-lib-without-dependency-information
usr/lib/x86_64-linux-gnu/libdcerpc-samr.so.0.0.1
W: libwbclient0: shared-lib-without-dependency-information
usr/lib/x86_64-linux-gnu/samba/libaesni-intel.so.0

# Easy
I: libwbclient0: symbols-file-missing-build-depends-package-field
I: libsmbclient: symbols-file-missing-build-depends-package-field

# Ignored:
I: samba-libs: no-symbols-control-file
usr/lib/x86_64-linux-gnu/libdcerpc-samr.so.0.0.1
I: samba-libs: no-symbols-control-file
usr/lib/x86_64-linux-gnu/libtevent-util.so.0.0.1
I: samba-libs: no-symbols-control-file
usr/lib/x86_64-linux-gnu/libdcerpc-server.so.0.0.1
I: samba-libs: no-symbols-control-file ... use --no-tag-display-limit
to see all (or pipe to a file/program)

# Investigate:
I: samba: package-contains-documentation-outside-usr-share-doc
usr/share/samba/setup/adprep/WindowsServerDocs/Forest-Wide-Updates.md
I: samba: package-contains-documentation-outside-usr-share-doc
usr/share/samba/setup/adprep/WindowsServerDocs/Schema-Updates.md

# Some work (and samba-common already exists)
I: samba: arch-dep-package-has-big-usr-share 13981kB 87%

>
> Al in all not to bad i think.
> I'll checkout the bug reports also, see what i can do there.

We need to know why the package is failing without your (broken) patch.

>
> Best regards,
>
> Louis

Regards

-- 
Mathieu