[Pkg-samba-maint] failed armhf build of samba 2:4.11.0+dfsg-1

[Andrew Bartlett]

On Thu, 2019-09-26 at 15:36 +0200, Mathieu Parent wrote:
> Hello Andrew,
> 
> The build on armel and armhf is still failing, now with:
> 
> Checking for __pwrite
>                          :
> E: Build killed with signal TERM after 150 minutes of inactivity
> 
> (All at: 
> https://buildd.debian.org/status/package.php?p=samba&suite=experimental
> )
> 
> Could we remove some more checks?

I think it shows that it isn't really about the __foo checks, but
certainly more of the checks should be removed.

To prove it, I did:

 - git grep -i have___foo
   (then confirm no references)
 - ./configure.developer && make -j
 - mv bin bin-save
 - git grep __foo
   (remove references in wscript, there may be multiple)
 - ./configure.developer && make -j
 - dirdiff bin bin-save
   (confirm build bin/default/config.h changes are sensible and the
rest of the build doesn't change)

Using ccache helps with the time taken.

Be particularly careful with the below exceptions:

~/samba$ git grep -i have___| cut -f 2 -d: | cut -f 2 -d\  | sort |
uniq

/*
defined(__GNUC__)
defined(HAVE___RES_CLOSE)
defined(HAVE___RES_INIT)
defined(HAVE___RES_NCLOSE)
defined(HAVE___RES_NINIT)
defined(HAVE___RES_NQUERY)
defined(HAVE___RES_NSEARCH)
defined(HAVE___RES_QUERY)
defined(HAVE___RES_SEARCH)
defined(HAVE___SECURE_GETENV)
defined(HAVE___STRTOLL)
defined(HAVE___STRTOULL)
defined(HAVE___SYNC_FETCH_AND_ADD)
HAVE___ATOMIC_THREAD_FENCE
HAVE___ATTRIBUTE__
HAVE___PMID_INT
HAVE___POSIX_GETGRGID_R
HAVE___POSIX_GETGRNAM_R
HAVE___POSIX_GETPWNAM_R
HAVE___POSIX_GETPWUID_R
HAVE___SS_FAMILY
HAVE___SYNC_SYNCHRONIZE
HAVE___THREAD
HAVE___VA_COPY

So certainly have a go, and propose a MR if you can.

Andrew Bartlett
-- 
Andrew Bartlett                       https://samba.org/~abartlet/
Authentication Developer, Samba Team  https://samba.org
Samba Developer, Catalyst IT          
https://catalyst.net.nz/services/samba