[Pkg-samba-maint] Bug#960171: max_update_suze(): bad call flug

[Andrew Bartlett]

I'm pleased to say this is fixed in Samba 4.12 with

commit f0eb1e623f76d3dbd0c22f96cabebd1041c147df
Author: Torsten Fohrer <torsten.fohrer at sbe.de>
Date:   Sun Dec 15 16:58:40 2019 +0100

    Avoiding bad call flags with python 3.8, using METH_NOARGS instead of zero.
    
    (C) SBE network solutions GmbH
    
    Signed-off-by: Torsten Fohrer <torsten.fohrer at sbe.de>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Dec 18 14:33:58 UTC 2019 on sn-devel-184

diff --git a/source4/auth/gensec/pygensec.c b/source4/auth/gensec/pygensec.c
index bc9d6bdcb16..986f32904e7 100644
--- a/source4/auth/gensec/pygensec.c
+++ b/source4/auth/gensec/pygensec.c
@@ -679,7 +679,7 @@ static PyMethodDef py_gensec_security_methods[] = {
                "S.have_feature()\n Return True if GENSEC negotiated a particular feature." },
        { "set_max_update_size",  (PyCFunction)py_gensec_set_max_update_size, METH_VARARGS,
                "S.set_max_update_size(max_size) \n Some mechs can fragment update packets, needs to be use before the mech is started." },
-       { "max_update_size",  (PyCFunction)py_gensec_max_update_size, 0,
+       { "max_update_size",  (PyCFunction)py_gensec_max_update_size, METH_NOARGS,
                "S.max_update_size() \n Return the current max_update_size." },
        { "update",  (PyCFunction)py_gensec_update, METH_VARARGS,
                "S.update(blob_in) -> (finished, blob_out)\nPerform one step in a GENSEC dance.  Repeat with new packets until finished is true or exception." },




On Sun, 2020-05-10 at 16:02 +0900, Tomoo Nomura wrote:
> Package: python3-samba
> Version: 2:4.11.5+dfsg-1+b1
> Severity: normal
> 
> Dear Maintainer,
> 
> samba-ad-dc can't start correctly. I checked samba_dnsupdate and found,
> 
> $sudo  samba_dnsupdate --verbose --all-names
> Traceback (most recent call last):
>   File "/usr/sbin/samba_dnsupdate", line 50, in <module>
>     from samba import gensec
> SystemError: max_update_size() method: bad call flags
> 
> 
> -- System Information:
> Debian Release: bullseye/sid
>   APT prefers testing
>   APT policy: (101, 'testing'), (100, 'stable'), (99, 'unstable')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 5.6.0-1-amd64 (SMP w/12 CPU cores)
> Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
> Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8), LANGUAGE=ja_JP.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
> 
> Versions of packages python3-samba depends on:
> ii  libbsd0         0.10.0-1
> ii  libc6           2.30-4
> ii  libldb2         2:2.0.8-2
> ii  libpython3.8    3.8.3~rc1-1
> ii  libtalloc2      2.3.0-5
> ii  libtevent0      0.10.1-4
> ii  libwbclient0    2:4.11.5+dfsg-1+b1
> ii  python3         3.8.2-3
> ii  python3-crypto  2.6.1-13.1+b1
> ii  python3-ldb     2:2.0.8-2
> ii  python3-talloc  2.3.0-5
> ii  python3-tdb     1.4.2-3+b1
> ii  samba-libs      2:4.11.5+dfsg-1+b1
> 
> Versions of packages python3-samba recommends:
> ii  python3-gpg  1.13.1-6
> 
> python3-samba suggests no packages.
> 
> -- no debconf information
> 
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba