[Pkg-samba-maint] master branch review

[Michael Tokarev]

02.04.2022 12:08, Michael Tokarev wrote:
> 02.04.2022 11:39, Mathieu Parent wrote:
...
>> - 9ab2a406b2972e18e1568963ecf4fe949d5d4921 "d/rules: specify the
>> package name for dh_installpam". The result is that the pam config is
>> kept in samba-common?
> 
> Yes it stayed in samba-common as it was before.  Maybe some day
> we'll move it to samba, - I just need to figure out how to move
> a conffile between packages, - it is different from moving a
> regular file, since we should preserve changes and transfer
> ownership.

Just to clarify.  It was:

     dh_installpam --name=samba

without -p package-name.  So, as for every dh_install* tool
out there, it iterated over all packages listed in d/control,
looking for debian/$package.samba.pam (with samba coming from
the --name= argument). But there's just one such file in
debian/ - namely, debian/samba-common.samba.pam.

If there were other files like eg debian/winbind.samba.pam
(there are none!), we'd end up having two different files
named /etc/pam.d/samba but in different packages.

I think dh_install* should produce a warning when they're
told to work on a single file (or pattern) but aren't
restricted to a specific package.

As for this our case, the same line now reads:

     dh_installpam -psamba-common --name=samba

which tells it to look up for a pam file named
"samba" in this particular package only. This
is how things actually *were* already, but it
wasn't explicit, it searched in *all* packages
instead, but by reality finding this file in
one package only.  So effectively nothing has
changed, this change just prevents possible
various surprises.

/mjt